Bug 9233 - internal dns server has a non handled out of memory case
Summary: internal dns server has a non handled out of memory case
Status: RESOLVED FIXED
Alias: None
Product: Samba 4.0
Classification: Unclassified
Component: DNS server (show other bugs)
Version: 4.0.0rc1
Hardware: All All
: P5 normal (vote)
Target Milestone: ---
Assignee: Karolin Seeger
QA Contact: Samba QA Contact
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-10-02 04:46 UTC by Matthieu Patou
Modified: 2012-10-02 06:49 UTC (History)
0 users

See Also:

Attachments
Proposed patch to fix the problem (783 bytes, patch)
2012-10-02 04:46 UTC, Matthieu Patou 		kai: review+
Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Matthieu Patou 2012-10-02 04:46:43 UTC 
Created attachment 7975 [details]
Proposed patch to fix the problem

Code of the internal dns server checks if the talloc_zero returns NULL but didn't act if it's the case leading to a segfault.
Comment 1 Kai Blin 2012-10-02 05:50:53 UTC 
Comment on attachment 7975 [details]
Proposed patch to fix the problem

Good catch
Comment 2 Kai Blin 2012-10-02 05:52:18 UTC 
Karolin, please pick for RC3.
Comment 3 Karolin Seeger 2012-10-02 06:49:24 UTC 
(In reply to comment #2)
> Karolin, please pick for RC3.

I am really glad that at least one person read my email! ;-)
Pushed to v4-0-test, because there were other fixes for rc2 also.

Closing out bug report.

Thanks!