Bug 9225 - dns server returns server fails when querying a record that has been dynamically removed
Summary: dns server returns server fails when querying a record that has been dynamica...
Status: RESOLVED FIXED
Alias: None
Product: Samba 4.0
Classification: Unclassified
Component: DNS server (show other bugs)
Version: 4.0.0rc1
Hardware: All All
: P5 major (vote)
Target Milestone: ---
Assignee: Karolin Seeger
QA Contact: Samba QA Contact
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-09-30 05:49 UTC by Matthieu Patou
Modified: 2012-10-01 07:22 UTC (History)
0 users

See Also:

Attachments
Trace with the described test case (21.46 KB, application/octet-stream)
2012-09-30 05:49 UTC, Matthieu Patou 		no flags Details
Patch for v4-0-test (3.59 KB, patch)
2012-09-30 09:31 UTC, Kai Blin 		mat: review+
abartlet: review+
Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Matthieu Patou 2012-09-30 05:49:04 UTC 
Created attachment 7960 [details]
Trace with the described test case

If a record do not exists in the database, the dns server returns "no such name".
Buf if the record was added and then deleted then queries on this record will return server fail.

It seems that this behaviour is quite perturbing for Windows client (windows 2008r2 server for sure).

How to reproduce: 
host -t a test.<domain> -> returns "no such name"
add a record with nsupdate -g
host -t a rest.<domain> -> returns the value
delete the record with nsupdate -g
host -t a rest.<domain> -> returns server fail
Comment 1 Kai Blin 2012-09-30 08:38:51 UTC 
ok, got it. Adding a test case and will then prepare a patch.
Comment 2 Kai Blin 2012-09-30 09:31:34 UTC 
Created attachment 7961 [details]
Patch for v4-0-test

This patch fixes the return code and more importantly fixes the test that should have caught the issue.

Please review the patch and assign to Karolin.
Comment 3 Kai Blin 2012-09-30 10:09:44 UTC 
Karolin, please pick for rc2
Comment 4 Matthieu Patou 2012-09-30 23:44:02 UTC 
Ok I think it should work, now the question is should we get rid of an dns related object if its dnsrecord is empty ?
Comment 5 Karolin Seeger 2012-10-01 07:22:56 UTC 
Pushed to autobuild-v4-0-test.
Closing out bug report.

Thanks!