Bug 9208 - Cannot migrate files with inheritance flags to share on top of NFSv4 filesystem
Summary: Cannot migrate files with inheritance flags to share on top of NFSv4 filesystem
Status: RESOLVED FIXED
Alias: None
Product: Samba 4.0
Classification: Unclassified
Component: File services (show other bugs)
Version: 4.0.0rc1
Hardware: All All
: P5 normal (vote)
Target Milestone: ---
Assignee: Karolin Seeger
QA Contact: Samba QA Contact
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-09-24 23:07 UTC by Christian Ambach
Modified: 2020-12-11 07:59 UTC (History)
0 users

See Also:

Attachments
Proposed patch (taken from master) (3.79 KB, patch)
2012-10-09 08:57 UTC, Christian Ambach 		vl: review+
Details
Patch (2.08 KB, patch)
2012-10-09 09:49 UTC, Volker Lendecke 		no flags Details
patchset against v4-0-test (6.02 KB, patch)
2012-10-16 08:40 UTC, Christian Ambach 		jra: review+
Details
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Christian Ambach 2012-09-24 23:07:00 UTC 
While it is possible to define inheritance flags on files on Windows, this will be denied by GPFS and UFS (and potentially others).

So it will be better to strip of these bits when being set for files instead of failing to set the ACL completely (this is current behavior).

Users that want to retain the full SD will have to use acl_xattr (acl_tdb), as other pieces of the SD are also lost when translating to NFSv4. So this should not be a too intrusive change, but allow users to migrate data with such flags instead of failing to migrate the ACL completely.
Comment 1 Christian Ambach 2012-10-09 08:57:23 UTC 
Created attachment 8016 [details]
Proposed patch (taken from master)
Comment 2 Volker Lendecke 2012-10-09 09:48:11 UTC 
Comment on attachment 8016 [details]
Proposed patch (taken from master)

Giving you an ack, asking for your ack on the next patch I'm about to upload...
Comment 3 Volker Lendecke 2012-10-09 09:49:00 UTC 
Created attachment 8017 [details]
Patch

Additional patch that is on its way through autobuild
Comment 4 Christian Ambach 2012-10-16 08:40:24 UTC 
Created attachment 8077 [details]
patchset against v4-0-test

new patchset which consists of all three patches
Comment 5 Jeremy Allison 2012-11-05 19:40:33 UTC 
Looks good to me for 4.0.0. Christian, if you want this in 4.0 please add me as reviewer and I'll +1.

Thanks !

Jeremy.
Comment 6 Jeremy Allison 2012-11-08 21:16:30 UTC 
Comment on attachment 8077 [details]
patchset against v4-0-test

LGTM
Comment 7 Jeremy Allison 2012-11-08 21:16:56 UTC 
Re-assigning to Karolin for inclusion in 4.0.0.rc.next.

Jeremy.
Comment 8 Karolin Seeger 2012-11-09 08:33:11 UTC 
Pushed all patches to autobuild-v4-0-test.
Comment 9 Karolin Seeger 2012-11-09 10:59:47 UTC 
Pushed to v4-0-test.
Closing out bug report.

Thanks!