Bug 9205 - pysmbd.c must properly set up a connection_struct
Summary: pysmbd.c must properly set up a connection_struct
Status: RESOLVED FIXED
Alias: None
Product: Samba 4.0
Classification: Unclassified
Component: AD: LDB/DSDB/SAMDB (show other bugs)
Version: 4.0.0rc1
Hardware: All All
: P5 normal (vote)
Target Milestone: ---
Assignee: Andrew Bartlett
QA Contact: Samba QA Contact
URL: https://git.samba.org/abartlet/samba....
Keywords:
Depends on:
Blocks: 9306
  Show dependency tree / graph
 
Reported: 2012-09-24 22:08 UTC by Volker Lendecke
Modified: 2013-06-27 08:48 UTC (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Volker Lendecke 2012-09-24 22:08:17 UTC 
pysmbd.c does not properly set up a connection_struct. For example it does not call the CONNECT method, which many modules depend upon
Comment 1 Andrew Bartlett 2012-10-18 07:15:04 UTC 
An attempt at this is in my vfs-connect branch.

However it is harder than it looks (due to 'samba-tool ntacl' not operating on a specific share). 

Given that the AD support only supports posix ACLs (yes, a test for that is hard-coded in provision) I suggest removing this as a blocker for 4.0, in the interests of making a release.
Comment 2 Karolin Seeger 2012-10-18 07:28:37 UTC 
(In reply to comment #1)
> An attempt at this is in my vfs-connect branch.
> 
> However it is harder than it looks (due to 'samba-tool ntacl' not operating on
> a specific share). 
> 
> Given that the AD support only supports posix ACLs (yes, a test for that is
> hard-coded in provision) I suggest removing this as a blocker for 4.0, in the
> interests of making a release.

Volker, do you agree on removing this as a blocker for 4.0?
Comment 3 Volker Lendecke 2012-10-18 09:35:55 UTC 
(In reply to comment #2)
> Volker, do you agree on removing this as a blocker for 4.0?

Difficult. If we see ourselves as a Posix ACL only DC, then sure, it will work. But the pysmbd.c code is just wrong not taking a share name as an argument. If we leave that around more python code might end up using that flawed API, making a fix later on harder. So, if our goal is to release S4 as quickly as possible, even with the cost to take more technical debt (https://en.wikipedia.org/wiki/Technical_debt), then this is not a blocker anymore. In the end, I will not block a release over this.
Comment 4 Andrew Bartlett 2012-11-14 06:29:41 UTC 
Removing the release blocker by the consent in comment #3.
Comment 5 Matthieu Patou 2012-11-23 22:00:47 UTC 
Reopening the bug, I guess the point volker made are valid I just don't think that this code will be really used outside so we still have an opportunity for 4.1 to make it right.
Comment 6 Andrew Bartlett 2013-06-27 08:48:28 UTC 
When a specific share is specified, this connection struct is now set up.