Bug 9150 - Valid open requests can cause smbd assert due to incorrect oplock handling on delete requests.
Summary: Valid open requests can cause smbd assert due to incorrect oplock handling on...
Status: RESOLVED FIXED
Alias: None
Product: Samba 3.6
Classification: Unclassified
Component: File services (show other bugs)
Version: unspecified
Hardware: All All
: P5 normal
Target Milestone: ---
Assignee: Karolin Seeger
QA Contact: Samba QA Contact
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-09-10 20:51 UTC by Jeremy Allison
Modified: 2012-09-12 08:24 UTC (History)
0 users

See Also:

Attachments
git-am fix for 3.6.x (1.40 KB, patch)
2012-09-10 21:11 UTC, Jeremy Allison 		vl: review+
Details
git-am fix for 3.5.next. (1.40 KB, patch)
2012-09-10 21:20 UTC, Jeremy Allison 		vl: review+
Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jeremy Allison 2012-09-10 20:51:33 UTC 
From Volker:

It seems that our is_delete_request handling in
delay_for_exclusive_oplocks is wrong. It seems that the only
difference between batch and exclusive oplocks is the time
of the check: Batch oplocks are broken before the share mode
check, exclusive ones after.

If you run the raw.oplock.exclusive8 test against current
versions of smbd, you will also find that we get a panic due
to an invalid share mode entry.

Attached also find the patches against v3-6-test and
v3-5-test.
Comment 1 Jeremy Allison 2012-09-10 21:11:11 UTC 
Created attachment 7872 [details]
git-am fix for 3.6.x

Volker's patch for 3.6.next. Already approved by jra.
Comment 2 Jeremy Allison 2012-09-10 21:20:25 UTC 
Created attachment 7873 [details]
git-am fix for 3.5.next.
Comment 3 Karolin Seeger 2012-09-12 08:24:01 UTC 
Pushed to v3-5-test and v3-6-test.
Closing out bug report.

Thanks!