Bug 9137 - smbclient allinfo does not show snapshot list
Summary: smbclient allinfo does not show snapshot list
Status: RESOLVED FIXED
Alias: None
Product: Samba 3.6
Classification: Unclassified
Component: Client Tools (show other bugs)
Version: 3.6.7
Hardware: All All
: P5 normal
Target Milestone: ---
Assignee: Karolin Seeger
QA Contact: Samba QA Contact
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-09-05 11:39 UTC by Christian Ambach
Modified: 2012-09-10 08:54 UTC (History)
0 users

See Also:

Attachments
patchset for 3.6.next (2.01 KB, patch)
2012-09-05 13:10 UTC, Christian Ambach 		vl: review+
Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Christian Ambach 2012-09-05 11:39:03 UTC 
using smbclient allinfo does not show shadow copy information because isFsctl flag is set wrong in the request
Comment 1 Christian Ambach 2012-09-05 11:41:16 UTC 
Has been fixed in master with 
commit 02aacb17d18f1bb47575b473a9468ff05403e67c
Author:     Christian Ambach <ambi@samba.org>
AuthorDate: Thu Aug 30 16:43:33 2012 +0200
Commit:     Christian Ambach <ambi@samba.org>
CommitDate: Thu Aug 30 18:57:24 2012 +0200

    s3:libsmb correctly set isFsctl for snapshot list
    
    FSCTL_GET_SHADOW_COPY_DATA is a FSCTL, so set the isFsctl marker
    otherwise smbclient allinfo will not report snapshots any more with the changes
    made for Bug #8311
    
    Autobuild-User(master): Christian Ambach <ambi@samba.org>
    Autobuild-Date(master): Thu Aug 30 18:57:24 CEST 2012 on sn-devel-104
Comment 2 Christian Ambach 2012-09-05 13:10:18 UTC 
Created attachment 7859 [details]
patchset for 3.6.next

Found another issue while testing this against Windows servers, see second patch
Comment 3 Jeremy Allison 2012-09-06 15:57:50 UTC 
Re-assigning to Karolin for inclusion in 3.6.next.

Jeremy.
Comment 4 Karolin Seeger 2012-09-10 08:54:31 UTC 
Pushed to v3-6-test.
Closing out bug report.

Thanks!