Bug 9104 - winbindd can mis-identify idle clients - can cause crashes and NDR parsing errors.
Summary: winbindd can mis-identify idle clients - can cause crashes and NDR parsing er...
Alias: None
Product: Samba 3.6
Classification: Unclassified
Component: Winbind (show other bugs)
Version: unspecified
Hardware: All All
: P5 critical
Target Milestone: ---
Assignee: Karolin Seeger
QA Contact: Samba QA Contact
Depends on:
Reported: 2012-08-20 20:16 UTC by Jeremy Allison
Modified: 2012-09-24 03:37 UTC (History)
1 user (show)

See Also:

git-am fix for 3.6.next. (1.96 KB, patch)
2012-08-20 22:21 UTC, Jeremy Allison
jra: review? (herb)
vl: review+
git-am fix for 3.5.next (1.88 KB, patch)
2012-08-20 23:03 UTC, Jeremy Allison
jra: review+

Note You need to log in before you can comment on or make changes to this bug.
Description Jeremy Allison 2012-08-20 20:16:35 UTC
Found by Herb.

The client_is_idle() function which determines the removal of inactive client connections incorrectly flags as idle the condition where a request has been sent to a winbindd child, (state->request != NULL), but no reply has yet been received from the child (state->request == NULL).

With a heavily loaded winbindd this can lead to client connections being terminated and responses being incorrectly returned.

Patch for 3.6.next to follow.
Comment 1 Jeremy Allison 2012-08-20 22:21:41 UTC
Created attachment 7796 [details]
git-am fix for 3.6.next.
Comment 2 Jeremy Allison 2012-08-20 23:03:36 UTC
Created attachment 7797 [details]
git-am fix for 3.5.next

Back-port of the patch for 3.5.next.
Comment 3 Jeremy Allison 2012-08-21 17:35:37 UTC
Comment on attachment 7797 [details]
git-am fix for 3.5.next

Herb for some reason can't set the '+' flag, so I'm setting it for him.

Comment 4 Jeremy Allison 2012-08-21 18:01:38 UTC
Re-assigning to Karolin for inclusion in 3.5.next and 3.6.next.

Comment 5 Jeremy Allison 2012-08-22 22:51:19 UTC
Hmmm. Used to be able to mark bugs "blocker", now "critical" seems the highest this can be set to.

This one really needs to go in as the fix explains many mysterious problems people may have had with winbindd under heavy load situations (Herb was only able to reproduce this with Swiftest).

Comment 6 Karolin Seeger 2012-08-23 18:17:25 UTC
Pushed to v3-5-test and v3-6-test.
Closing out bug report.