Bug 9025 - samba 4.0.0beta3 fails to build with perl 5.16
samba 4.0.0beta3 fails to build with perl 5.16
Status: RESOLVED FIXED
Product: Samba 4.0
Classification: Unclassified
Component: Build
4.0 beta3
All All
: P5 normal
: ---
Assigned To: Andrew Tridgell
samba4-qa@samba.org
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-07-03 16:09 UTC by Torsten Kurbad
Modified: 2012-07-04 10:12 UTC (History)
0 users

See Also:


Attachments
samba-4.0.0_beta3-perl-5.16.patch (646 bytes, patch)
2012-07-03 16:09 UTC, Torsten Kurbad
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Torsten Kurbad 2012-07-03 16:09:03 UTC
Created attachment 7687 [details]
samba-4.0.0_beta3-perl-5.16.patch

In Perl 5.16, the getopts.pl module has been removed. Hence, compilation fails with the following error:

[ 159/3654] Generating ../heimdal/lib/asn1/der-private.h
Can't locate getopts.pl in @INC (@INC contains: /etc/perl /usr/local/lib64/perl5/5.16.0/x86_64-linux /usr/local/lib64/perl5/5.16.0 /usr/lib64/perl5/vendor_perl/5.16.0/x86_64-linux /usr/lib64/perl5/vendor_perl/5.16.0 /usr/lib64/perl5/5.16.0/x86_64-linux /usr/lib64/perl5/5.16.0 .) at /var/tmp/portage/net-fs/samba-4.0.0_beta3/work/samba-4.0.0beta3/source4/heimdal/cf/make-proto.pl line 5.
Can't locate getopts.pl in @INC (@INC contains: /etc/perl /usr/local/lib64/perl5/5.16.0/x86_64-linux /usr/local/lib64/perl5/5.16.0 /usr/lib64/perl5/vendor_perl/5.16.0/x86_64-linux /usr/lib64/perl5/vendor_perl/5.16.0 /usr/lib64/perl5/5.16.0/x86_64-linux /usr/lib64/perl5/5.16.0 .) at /var/tmp/portage/net-fs/samba-4.0.0_beta3/work/samba-4.0.0beta3/source4/heimdal/cf/make-proto.pl line 5.
Waf: Leaving directory `/var/tmp/portage/net-fs/samba-4.0.0_beta3/work/samba-4.0.0beta3/bin'
Build failed:
 -> task failed (err #2): 
	{task: ../heimdal/lib/asn1/der-protos.h der_get.c,der_put.c,der_free.c,der_format.c,der_length.c,der_copy.c,der_cmp.c -> der-protos.h}
 -> task failed (err #2): 
	{task: ../heimdal/lib/asn1/der-private.h der_get.c,der_put.c,der_free.c,der_format.c,der_length.c,der_copy.c,der_cmp.c -> der-private.h}


The attached patch fixes the problem in a (hopefully) backwards compatible way.
Comment 1 Torsten Kurbad 2012-07-04 07:53:34 UTC
JFI: I've tested the patch with Perl 5.12.4 now, and it works. Anyhow, I don't know, what minimum version requirements Samba 4 has for Perl, and neither do I know, whether this patch works with that minimum version, too.

So, it would be great if someone could test that.
Comment 2 Björn Jacke 2012-07-04 10:12:33 UTC
thanks, will be fixed in beta4.