Created attachment 7681 [details]
cppcheck full report
I runned cppcheck (a static analyzer) on Samba sources git updated today.
I used the option "--enable=all" to have a full report.
You'll keep the complete report attached.
Keep in mind that there can be false positives.
Hope it helps.
Very interesting, but we would really need this running on an automated host, and then someone interested in doing the work to sort out which non-style changes are not a false-positive and are a real issue.
I'm closing this for now.