./smbcacls Usage: smbcacls [-?] [-?tV] [-?tV] [-?tVNkPeC] [-?|--help] [--usage] [-D|--delete ACL] [-M|--modify ACL] [-a|--add ACL] [-S|--set ACLS] [-C|--chown USERNAME] [-G|--chgrp GROUPNAME] [--numeric] [-t|--test-args] [-d|--debuglevel DEBUGLEVEL] [-s|--configfile CONFIGFILE] [-l|--log-basename LOGFILEBASE] [-V|--version] [-O|--socket-options SOCKETOPTIONS] [-n|--netbiosname NETBIOSNAME] [-W|--workgroup WORKGROUP] [-i|--scope SCOPE] [-U|--user USERNAME] [-N|--no-pass] [-k|--kerberos] [-A|--authentication-file FILE] [-S|--signing on|off|required] [-P|--machine-pass] [-e|--encrypt] [-C|--use-ccache] //server1/share1 filename ACLs look like: 'ACL:user:[ALLOWED|DENIED]/flags/permissions' From the usage, we can see that the "-S" option is both used for "--set ACLS" and "--signing on|off|required".
The same applies to smbcquotas and subtree
ups, meant to write smbtree
Douglas did a presentation at SambaXP on this: https://sambaxp.org/archive-data-samba/SambaXP2019-SLIDES/dbagnall-what-should-we-do-with-our-ui.pdf
The slides contain lots of findings beside the -S issue in this bug, but no proposal for a fix. Did something come up in the discussion of the talk or so? Any discussions on samba-technical? If we look at the -S dilemma, we could do two different things: -switch the -S parameters of the tools to another letter, to that the original -S becomes usable again. Drawback: we are changing the interface of the tools, users need to adjust scripts etc -remove the -S is for signing line from the --help outputs to represent how the tools have behaved in the past years. Good stuff: no change for users However, fixing other letters than -S might become more difficult to fix by breaking up the existing arrays like popt_common_credentials into small enough chunks to catch the different combinations. I would prefer not to change user experience, but we can also open up a discussion on the mailing list and ask for other's opinions.
(In reply to Christian Ambach from comment #4) Yes, we shouldn't change the actual behaviour of the scripts (at least on behalf of this bug), but change the --help and usage strings to reflect the true behaviour. Another way to do it would be to take ownership of third_party/popt and adapt it so it only shows the options that are in effect. There was quite a bit of discussion in the room, but no fixes came out of it.
fixed with 4.15 (and the removal of the -S flag for signing)