The Samba-Bugzilla – Bug 8976
uninitialized variable in mount.cifs 5.5
Last modified: 2012-10-12 10:49:20 UTC
The mount.cifs program from the cifs-utils package 5.5 did not work on my Linux system. It just exited without an error message and did not mount anything.
A little debugging brought me to the following "change log" entry:
>> mount.cifs: toggle_dac_capability() stores return code
>> the build process of the cifs-utils for Mandriva 2011 made me notice of
>> the unused variable rc in toggle_dac_capability() of mount.cifs.c.
>> A bit up in the code we store the return value and do not make use of it
>> while calling return.
I think, when this variable rc is now used in this function, it has also to be properly initialized there.
A test with rc = 0 at the beginning of the function made the mount program work again.
That appears to be correct. rc should be initialized to 0. Do you want to spin up a patch and send it to email@example.com? Or would you rather I do it?
(In reply to comment #1)
> That appears to be correct. rc should be initialized to 0. Do you want to spin
> up a patch and send it to firstname.lastname@example.org? Or would you rather I do
Please do it.
Although it looks like a trivial patch, I would prefer that one of the program maintainers makes the actual changes. ;-)
This should now be fixed...