Samba server, mount.cifs client only - group write bit always set on directory created with unix extensions enabled, I mean client umask is being honored at all bits, except group write bit. If I disable unix extensions, then it works ok ("directory mask" parameter is working ok). Smbclient and Windows clients work fine (no unix extensions involved (smbclient - why not?)). File creation works fine - umask is working. Config parameters except "unix extensions" seem not involved in this bug, tried with ldap based auth, plain user auth, directory modes and more, nothing changed. For reproducing just use default config with writable share. Tried that with 3.4.7 Samba server - everything works as it should. Servers affected: Samba 3.5.15 (Gentoo), 3.6.5 (Gentoo), 3.6.3 (Ubuntu 12.04) Server unaffected: 3.4.7 (Ubuntu 10.04) Clients used: mount.cifs 5.4 (Gentoo 3.2.16 kernel), mount.cifs 1.12-3.4.7 (Ubuntu 10.04 2.6.32-41 kernel)
I need to see your smb.conf file please - the exact one you use to reproduce this. Jeremy.
Created attachment 7624 [details] my smb.conf in Ubuntu 12.04 Ubuntu 12.04 smb.conf with comments stripped. Checked the config after clearing, it still works the same way.
Created attachment 7626 [details] git-am fix for 3.5.next and also 3.6.next. Obvious fix - we can't mess with file_attributes on a POSIX call.
Comment on attachment 7626 [details] git-am fix for 3.5.next and also 3.6.next. I will write a test for this for master.
We should get this in for next release. Jeremy.
Created attachment 7627 [details] Test patchset I added to master.
Comment on attachment 7627 [details] Test patchset I added to master. NB. No review needed, this is informational only to show how I have prevented any regressions for this bug in the future. Jeremy.
Created attachment 7628 [details] (Slightly fixed) tests I added to master. No review needed, just informational.
Making it a blocker to make sure we don't release another 3.6.x or 3.5.x without this patch, it's a simple fix (but important) we really should get into the next release. Jeremy.
Comment on attachment 7626 [details] git-am fix for 3.5.next and also 3.6.next. It is probably the minimum necessary change. I would assert however that overloading the file_attributes parameter to VFS_CREATEFILE depending on FILE_FLAG_POSIX_SEMANTICS is really bad design. The real fix IMHO is to have a separate parameter for the posix calls.
Re-assigning to Karolin for inclusion in 3.5.next and 3.6.next. +1 on that being a REALLY BAD design :-). Sorry for that. Let's look into fixing it for the 4.0.x release. Thanks for the review. Jeremy.
Patch does not apply to current v3-6-test (ec7a5f259). Re-assigning to Jeremy.
Created attachment 7642 [details] Updated patch for v3-6-test only. Sorry for the problem. Here's the same patch updated for v3-6-test. Jeremy.
Re-assigning to Karolin for inclusion in 3.6.next. Jeremy.
(In reply to comment #13) > Created attachment 7642 [details] > Updated patch for v3-6-test only. > > Sorry for the problem. Here's the same patch updated for v3-6-test. > Jeremy. Thanks a lot, Jeremy! Pushed to v3-6-test and v3-5-test. Closing out bug report. Thanks!