Bug 8968 - shadow_copy2 patch corrects module functionality on Windows 7/Vista
Summary: shadow_copy2 patch corrects module functionality on Windows 7/Vista
Status: NEW
Alias: None
Product: Samba 3.6
Classification: Unclassified
Component: VFS Modules (show other bugs)
Version: 3.6.5
Hardware: All FreeBSD
: P5 normal
Target Milestone: ---
Assignee: Samba Bugzilla Account
QA Contact: Samba QA Contact
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-05-31 14:22 UTC by Artem
Modified: 2012-06-03 17:54 UTC (History)
1 user (show)

See Also:

Attachments
vfs_shadow_copy2 patch (FreeBSD 9 tested) (2.45 KB, patch)
2012-05-31 14:22 UTC, Artem 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Artem 2012-05-31 14:22:43 UTC 
Created attachment 7613 [details]
vfs_shadow_copy2 patch (FreeBSD 9 tested)

The patch attached extends the idea of Bug 7913 https://bugzilla.samba.org/show_bug.cgi?id=7913
and gives full functionality on windows 7.
There was an error in method of converting virtual paths to real (convert_shadow2_name function). It kept trailing slashes (one or double depending on using basedir)
Also  shadow_copy2_connectpath returned virtual path, what caused an error.
I fixed it with some code duplicating from convert_shadow2_name and now it works fine

Patch tested on FreeBSD 9.0