Bug 8945 - vfs_acl_common discards errors from writing to the underlying storage
Summary: vfs_acl_common discards errors from writing to the underlying storage
Status: RESOLVED FIXED
Alias: None
Product: Samba 3.6
Classification: Unclassified
Component: VFS Modules (show other bugs)
Version: 3.6.3
Hardware: All All
: P5 normal
Target Milestone: ---
Assignee: Karolin Seeger
QA Contact: Samba QA Contact
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-05-17 12:57 UTC by Richard Sharpe
Modified: 2012-05-19 18:41 UTC (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Richard Sharpe 2012-05-17 12:57:24 UTC 
When calling create_acl_blob and calling store_acl_blob_fsp vfs_acl_common.c:fset_nt_acl_common discards the return status from both of those functions. Thus it us unable to report errors to Windows.

store_acl_blob_fsp also clobbers errno if log level = 10.
Comment 1 Richard Sharpe 2012-05-17 12:58:37 UTC 
This is fixed in master with changes 876a8d456fcfc93f5c3f44c95f4579b5c05c3512 and bfe4a2baeec6bc4558a617ec67532ea11f865861
Comment 2 Jeremy Allison 2012-05-17 19:20:32 UTC 
+1 from me.

Actual commands needed to pull are:

git cherry-pick -x bfe4a2baeec6bc4558a617ec67532ea11f865861
git cherry-pick -x 632af6645376185500820a5be9dbf5c0c3d1e515

Re-assigning to Karolin for inclusion.

Jeremy.
Comment 3 Karolin Seeger 2012-05-19 18:41:34 UTC 
Pushed to v3-6-test.
Closing out bug report.

Thanks!