Bug 8859 - Wrong assertion: Checks pointer not value
Summary: Wrong assertion: Checks pointer not value
Status: RESOLVED FIXED
Alias: None
Product: Samba 3.6
Classification: Unclassified
Component: File services (show other bugs)
Version: 3.6.4
Hardware: All All
: P5 normal
Target Milestone: ---
Assignee: Karolin Seeger
QA Contact: Samba QA Contact
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-04-12 11:17 UTC by Olaf Flebbe
Modified: 2012-05-07 16:24 UTC (History)
0 users

See Also:

Attachments
patch (957 bytes, patch)
2012-04-12 11:18 UTC, Olaf Flebbe 		jra: review+
Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Olaf Flebbe 2012-04-12 11:17:29 UTC 
In the same file pointers have a positive check. 
IMHO hhis does not make sense. The value the pointer points to has to be checked.

Same error in 3.6.4 and master.
Comment 1 Olaf Flebbe 2012-04-12 11:18:14 UTC 
Created attachment 7449 [details]
patch
Comment 2 Jeremy Allison 2012-04-12 22:48:33 UTC 
Comment on attachment 7449 [details]
patch

Obviously correct.
Comment 3 Jeremy Allison 2012-04-12 22:49:01 UTC 
Re-assigning to Karolin for inclusion in 3.6.next.
Comment 4 Karolin Seeger 2012-05-07 16:24:46 UTC 
Pushed to v3-6-test.
Closing out bug report.

Thanks!