Bug 8786 - Add OpenBSD utmp support
Summary: Add OpenBSD utmp support
Status: NEW
Alias: None
Product: Samba 3.6
Classification: Unclassified
Component: Build environment (show other bugs)
Version: 3.6.3
Hardware: All OpenBSD
: P5 normal
Target Milestone: ---
Assignee: Brad Smith
QA Contact: Samba QA Contact
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-03-01 07:09 UTC by Brad Smith
Modified: 2012-11-17 03:13 UTC (History)
1 user (show)

See Also:

Attachments
Add utmp support for OpenBSD (2.25 KB, patch)
2012-03-01 07:09 UTC, Brad Smith 		no flags Details
Add utmp support for OpenBSD (2.18 KB, patch)
2012-11-17 02:59 UTC, Brad Smith 		no flags Details
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brad Smith 2012-03-01 07:09:44 UTC 
Created attachment 7354 [details]
Add utmp support for OpenBSD

The attached patch adds utmp support for OpenBSD. This has been in our ports tree for 6.5 years so I might as well try to push it upstream now. :)
Comment 1 Brad Smith 2012-08-24 17:27:59 UTC 
Any chance of review and having this commited to the tree?
Comment 2 Volker Lendecke 2012-08-26 13:04:46 UTC 
Can the error handling be improved? If intermediate steps fail, right now the patch creates a fd leak.

Question: Is this really the BSD way to do the pututline operation? To me this seems quite crude. Do you have a sample snippet somewhere from OpenBSD code?

Thanks,

Volker
Comment 3 Brad Smith 2012-11-17 02:59:41 UTC 
Created attachment 8210 [details]
Add utmp support for OpenBSD
Comment 4 Brad Smith 2012-11-17 03:13:33 UTC 
I fixed the fd leaks with this second revision of the diff. I am not familiar enough with the handling of utmp on OpenBSD so I have asked some of our other developers to comment on this diff.