Bug 8766 - update-waf script doesn't work on darwin
Summary: update-waf script doesn't work on darwin
Status: RESOLVED FIXED
Alias: None
Product: Samba 4.0
Classification: Unclassified
Component: Other (show other bugs)
Version: unspecified
Hardware: All All
: P5 normal (vote)
Target Milestone: ---
Assignee: Andrew Bartlett
QA Contact: samba4-qa@samba.org
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-02-19 08:15 UTC by Dave Abrahams
Modified: 2012-02-19 18:57 UTC (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dave Abrahams 2012-02-19 08:15:41 UTC 
This patch fixes it:


--- a/buildtools/update-waf.sh
+++ b/buildtools/update-waf.sh
@@ -2,7 +2,7 @@
 # Update our copy of waf
 
 TARGETDIR="`dirname $0`"
-WORKDIR="`mktemp -d`"
+WORKDIR="`mktemp -d -t update-waf`"
 
 mkdir -p "$WORKDIR"
Comment 1 Jelmer Vernooij 2012-02-19 14:26:10 UTC 
I guess this is fine as a patch, though it shouldn't really be necessary for normal users to run update-waf.sh. We only use it to update our copy of waf whenever there is a relevant bug fix in waf upstream.
Comment 2 Dave Abrahams 2012-02-19 17:43:03 UTC 
I'm not an ordinary user :-)
Comment 3 Matthias Dieter Wallnöfer 2012-02-19 18:57:56 UTC 
I've pushed this to "master".