Bug 8749 - SMB2: SessionSetup responses are not signed
Summary: SMB2: SessionSetup responses are not signed
Status: RESOLVED FIXED
Alias: None
Product: Samba 3.6
Classification: Unclassified
Component: SMB2 (show other bugs)
Version: 3.6.3
Hardware: All All
: P5 normal
Target Milestone: ---
Assignee: Karolin Seeger
QA Contact: Samba QA Contact
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-02-08 13:41 UTC by Christian Ambach
Modified: 2012-09-19 00:00 UTC (History)
2 users (show)

See Also:

Attachments
patch for 3-6-test (2.41 KB, patch)
2012-02-08 13:41 UTC, Christian Ambach 		metze: review-
Details
Patchset for 3.6 test (3.17 KB, patch)
2012-02-08 13:58 UTC, Christian Ambach 		metze: review+
Details
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Christian Ambach 2012-02-08 13:41:43 UTC 
Created attachment 7306 [details]
patch for 3-6-test

This makes smbtorture in master aborting smb2 tests when not giving -Srequired because smbXcli expects the SessSetup reponses to be signed (and Windows servers send them signed)

It's already fixed in master in 39dcf4bf02d1.

Original patch does not apply to 3.6 branch cleanly, thus attaching patch for v3-6-test
Comment 1 Christian Ambach 2012-02-08 13:42:20 UTC 
Forgot to say that this blocks running smbtorture against 3.6.3. It runs fine against master
Comment 2 Stefan Metzmacher 2012-02-08 13:51:31 UTC 
Comment on attachment 7306 [details]
patch for 3-6-test

You also need commit 1bb6e6758cffea967b6b8
Comment 3 Christian Ambach 2012-02-08 13:58:55 UTC 
Created attachment 7307 [details]
Patchset for 3.6 test

Ok, next try this time including the second fix for guest setups
Comment 4 Stefan Metzmacher 2012-02-08 15:47:29 UTC 
Comment on attachment 7307 [details]
Patchset for 3.6 test

Looks good
Comment 5 Stefan Metzmacher 2012-02-08 15:47:56 UTC 
Karolin, please pick for the next release
Comment 6 Karolin Seeger 2012-02-12 20:01:28 UTC 
Pushed to v3-6-test.
Closing out bug report.

Thanks!