If winbind is not started with a configuration file called smb.conf, the pid file will be named <lock_dir>/winbind-<name_of_smb.conf>.pid. smbcontrol only search for <lock_dir>/winbind.pid.
Created attachment 7249 [details] Proposed solution to fix the problem
The attached patch fix the problem by having the same method for pid name calculation in pidfile_pid and in pidfile_create
Comment on attachment 7249 [details] Proposed solution to fix the problem This introduces a memory leak, some SAFE_FREE(name) calls are missing
Created attachment 7253 [details] Updated fix with SAFE_FREE added. Matthieu and Metze, how about this instead ? Jeremy.
Comment on attachment 7253 [details] Updated fix with SAFE_FREE added. Looks good
Comment on attachment 7253 [details] Updated fix with SAFE_FREE added. Jeremy, please upload a git patch and assign to Karolin for 3.6.2
Attention with this patch make test fails on the s3's winbind test due to nmbd dropping GETDC request which are originating from the same ip as the nmbd server.
(In reply to comment #7) > Attention with this patch make test fails on the s3's winbind test due to nmbd > dropping GETDC request which are originating from the same ip as the nmbd > server. That's a different bug, which we already have if someone uses the default smb.conf, right? This just makes the behavior (maybe including bugs) consistent between the case where we use the default smb.conf and the case where we use a different config file. metze
Just try to make test with this patch and you will see that there is a problem. The reason why this occurs is that with this patch, winbind is now able to find nmbd when running in make test (because nmbd is started with a server.conf configuration file) so it tries to get the DC via netbios calls and it fails because nmbd drops the request. Before this patch winbind in make test wasn't finding nmbd (because it looked for a different pid file) and so used another method to get the DC.
Metze, so this a showstopper for 3.6.2?
No - this is not a showstopper for 3.6.2 (IMHO). It only affects sites where smb.conf isn't used for winbindd - not a large number. Jeremy.
Metze, so this a showstopper for 3.6.2?(In reply to comment #11) > No - this is not a showstopper for 3.6.2 (IMHO). It only affects sites where > smb.conf isn't used for winbindd - not a large number. > > Jeremy. Thanks for your feedback, Jeremy! :-)
Yeah, can't check this in until I can resolve the "make test" issue..
I think we can leave this for 3.6.3.
Patch pushed to master: 9b43ad4fcac1eb6796973336c5614b18a054080d
Created attachment 7339 [details] git-am fix for 3.6.next
Comment on attachment 7339 [details] git-am fix for 3.6.next Looks good
Karolin, please pick this for the release
Pushed to v3-6-test. Closing out bug report. Thanks!