Bug 8711 - s3 autoconf build broke
s3 autoconf build broke
Status: CLOSED FIXED
Product: Samba 4.0
Classification: Unclassified
Component: Other
unspecified
All All
: P2 critical
: ---
Assigned To: Andrew Bartlett
samba4-qa@samba.org
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-01-20 15:11 UTC by Christian Ambach
Modified: 2016-05-12 13:30 UTC (History)
1 user (show)

See Also:


Attachments
Patch to add -lz when required (996 bytes, patch)
2012-01-20 20:19 UTC, Andrew Bartlett
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Christian Ambach 2012-01-20 15:11:48 UTC
Cannot build source3 anymore with autoconf build since 60e1aa701c came into the tree. Multiple binaries fail to build with missing dependencies,

e.g.
$ make bin/wbinfo
Compiling ../dynconfig/dynconfig.c
Compiling ../nsswitch/wb_common.c
../nsswitch/wb_common.c: In function ‘make_nonstd_fd_internals’:
../nsswitch/wb_common.c:85:49: warning: unused parameter ‘limit’
Linking shared library bin/libwbclient.so.0
Linking bin/wbinfo
/usr/bin/ld: ../librpc/ndr/ndr_compression.o: undefined reference to symbol 'inflateInit2_'
/usr/bin/ld: note: 'inflateInit2_' is defined in DSO /lib64/libz.so.1 so try adding it to the linker command line
/lib64/libz.so.1: could not read symbols: Invalid operation

adding ZLIB_LIBS as dependency didn't help, it then fails with krb5 errors
Comment 1 Andrew Bartlett 2012-01-20 20:18:41 UTC
I do apologise, a lack of communication on my part with metze meant that I didn't propose to him a followup patch that addressed the -lz issue.

I'll attach my patch to this bug, and autobuild it.

Make sure to re-run configure, and be on a host with MIT krb5 1.8 or Heimdal 1.x, as these are our new minimum supported versions (per on-list discussion).
Comment 2 Andrew Bartlett 2012-01-20 20:19:26 UTC
Created attachment 7246 [details]
Patch to add -lz when required
Comment 3 Stefan Metzmacher 2012-01-20 21:55:20 UTC
I'm not sure if this is still needed after 
https://gitweb.samba.org/?p=samba.git;a=commitdiff;h=5c88cfcc525290d0ad1c3224
Comment 4 Christian Ambach 2012-01-23 19:12:09 UTC
master build is working again
Comment 5 Stefan Metzmacher 2012-01-23 23:11:46 UTC
Hi Christian,

does it also work if you revert?
https://gitweb.samba.org/?p=samba.git;a=commitdiff;h=88daf798fec56a99e5eb3aed67f

metze
Comment 6 Andrew Bartlett 2012-01-24 12:02:38 UTC
Metze,

Thanks for chasing this up.  If confirmed, it looks to me like Volker and I were in an autobuild race with alternate solutions, with Volker's patch being the better one.
Comment 7 Stefan Metzmacher 2012-01-24 13:51:33 UTC
O(In reply to comment #6)
> Metze,
> 
> Thanks for chasing this up.  If confirmed, it looks to me like Volker and I
> were in an autobuild race with alternate solutions, with Volker's patch being
> the better one.

Ok, then I'll revert it later today.