From Ira Cooper <ira@wakeful.net>

There's a major leak in connections.tdb.  I finally root caused it and did
the plumbing to fix it.  (you may disagree with my fix.  But it appears to
nail the issue.)

Basically it leaks all connections according to my tests, and this is why
our servers end up with 3GB+ connections.tdb files.  (We've seen this for a
while now, but never gotten close to the root cause until last week.)

Patch enclosed.

To replicate: net use n: \\samba-server\share
net use /delete n:

Then use tdbtooll to see the extra records left behind.

The issue is that the cnum in the connection for smb2 is initialized before
the actual connection is setup, and not passed into make_connection_snum.
 I just plumbed it in, with a boolean to say if it was passed.  (I'm
assuming it can be zero.)