Bug 8708 - Compile error at origin/master
Compile error at origin/master
Status: RESOLVED FIXED
Product: Samba 3.6
Classification: Unclassified
Component: Build environment
unspecified
All All
: P5 normal
: ---
Assigned To: Björn Jacke
Samba QA Contact
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-01-17 10:59 UTC by Christoph Theis
Modified: 2012-02-23 17:29 UTC (History)
3 users (show)

See Also:


Attachments
Patch to fix a compile error at source3/lib/util.c (491 bytes, text/plain)
2012-01-17 10:59 UTC, Christoph Theis
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Christoph Theis 2012-01-17 10:59:25 UTC
Created attachment 7242 [details]
Patch to fix a compile error at source3/lib/util.c

When I try to compile the sources from git under FreeBSD 9.0, I get a compile error at source3/lib/util.c that it could not find "tdb.h". This is very much the same as https://bugzilla.samba.org/show_bug.cgi?id=8468
For me it looks like LIB_SRC was split and in LIB_UTIL_SRC the dependency on tdb is missing. I attach a patch (derived from what you did in the aforementioned bug) to solve this.
Comment 1 Matthias Dieter Wallnöfer 2012-01-17 19:43:12 UTC
Gd, obnox, could you please have a look at this change?
Comment 2 Matthias Dieter Wallnöfer 2012-01-17 20:02:27 UTC
The bugs lie in Samba 3.x-specific parts of the WAF build system.
Comment 3 Matthias Dieter Wallnöfer 2012-02-23 07:54:48 UTC
A fix based on your patch has been pushed to "master".
Comment 4 Christoph Theis 2012-02-23 17:29:15 UTC
The #ifdef HAVE_UTMP_H was not enough. Now the compiler doesn't look for utmp.h, but it still comes to uses of struct utmp, because WITH_UTMP is still defined.