Bug 8692 - ads_keytab_verify_ticket mixes talloc allocation with malloc free.
Summary: ads_keytab_verify_ticket mixes talloc allocation with malloc free.
Status: RESOLVED FIXED
Alias: None
Product: Samba 3.6
Classification: Unclassified
Component: File services (show other bugs)
Version: unspecified
Hardware: All All
: P5 normal
Target Milestone: ---
Assignee: Karolin Seeger
QA Contact: Samba QA Contact
URL:
Keywords:
Depends on:
Blocks: 8595
  Show dependency tree / graph
 
Reported: 2012-01-10 00:04 UTC by Jeremy Allison
Modified: 2020-12-11 07:29 UTC (History)
0 users

See Also:

Attachments
git-am fix for 3.6.x (698 bytes, patch)
2012-01-10 00:05 UTC, Jeremy Allison 		gd: review+
vl: review+
Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jeremy Allison 2012-01-10 00:04:06 UTC 
Found by Guenther, smb_krb5_unparse_name() returns a talloc'ed name which is then passed to SAFE_FREE. This needs changing to TALLOC_FREE in 3.6.x (master commit c3f9e011edbab66f317df97b9ceca7b70f45d739).
Comment 1 Jeremy Allison 2012-01-10 00:05:44 UTC 
Created attachment 7234 [details]
git-am fix for 3.6.x

Guenther, please confirm and I'll re-assign to Karolin for inclusion in 3.6.next.
Comment 2 Jeremy Allison 2012-01-10 00:07:30 UTC 
Comment on attachment 7234 [details]
git-am fix for 3.6.x

Volker or Metze, if you have time to review..
Comment 3 Jeremy Allison 2012-01-10 00:09:51 UTC 
Comment on attachment 7234 [details]
git-am fix for 3.6.x

FYI. Patch also applies and is needed for 3.5.x also.

Jeremy.
Comment 4 Guenther Deschner 2012-01-10 11:28:50 UTC 
Karolin, please apply to 3.5 and 3.6. Thanks!
Comment 5 Karolin Seeger 2012-01-10 20:08:31 UTC 
Pushed to both branches.
Closing out bug report.

Thanks!