Bug 8685 - lpcfg_gensec_settings uses talloc_reference
Summary: lpcfg_gensec_settings uses talloc_reference
Status: REOPENED
Alias: None
Product: Samba 4.0
Classification: Unclassified
Component: Other (show other bugs)
Version: unspecified
Hardware: All All
: P5 regression (vote)
Target Milestone: ---
Assignee: Andrew Bartlett
QA Contact: samba4-qa@samba.org
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-01-02 13:46 UTC by Volker Lendecke
Modified: 2012-11-16 10:54 UTC (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Volker Lendecke 2012-01-02 13:46:34 UTC 
lpcfg_gensec_settings implicitly takes a talloc_reference of the lp_ctx. This must be replaced, for example by explicitly taking all gensec-relevant parameters in this routine or by hiding the referenced object behind a wrapper, much like tdb_wrap does it.
Comment 1 Michael Adam 2012-11-06 10:52:01 UTC 
Has anything changed since January?
Im am not aware of anything.

I understand this bug report as pointing out a bad and potentially dangerous design. I have not yet seen concrete crashes or similar. Are there such reports?

- Can we do anything about it in the near future?
- Is this really blocking the 4.0 release or is it rather "technical debt" that we should try to fix for 4.0, but would not mean the end of the world if it gets fixed later?

This is not biased in any way, I just want to understand.

Thanks - Michael
Comment 2 Michael Adam 2012-11-16 10:52:59 UTC 
Let's not close the bug, but remove it from the blocker list instead, if we can't do it for 4.0.
Comment 3 Michael Adam 2012-11-16 10:54:26 UTC 
don't block the release for this one.