Created attachment 7154 [details]
patch for master
In Samba 3.6 the format for the cache entries has been changed. So if you have 'winbind offline logon = on' set and you update from 3.5 to 3.6 the cache gets removed cause the validation fails.
The attached patch adds code to upgrade the database format. Please review and push to master if you're fine with it.
Doesn't this patch leak memory ?
Who frees the blob allocated with SMB_XMALLOC_ARRAY ?
Yes, it does. Thanks for fixing it. So if this is patch is fine, then Karolin could pick
for 3.6.2 right?
Created attachment 7156 [details]
git-am fix for 3.6.2
Yes, this is the one. If you're happy review as +1 and re-assign to Karolin for inclusion.
Karolin, could you please pick the patch for 3.6. Thanks!
Patch does not apply to current v3-6-test (33a8e16140):
user@host:/data/git/samba/v3-6-test> git am 0001-s3-winbind-Add-an-update-function-for-winbind-cache.patch
Applying: s3-winbind: Add an update function for winbind cache.
error: patch failed: source3/winbindd/winbindd_cache.c:4093
error: source3/winbindd/winbindd_cache.c: patch does not apply
Patch failed at 0001 s3-winbind: Add an update function for winbind cache.
Created attachment 7158 [details]
Updated git-am fix that should apply to 3.6.2.
Sorry about that - updated fix attached.
(In reply to comment #6)
> Created attachment 7158 [details]
> Updated git-am fix that should apply to 3.6.2.
> Sorry about that - updated fix attached.
Pushed to v3-6-test. Thanks a lot!
Closing out bug report.