Bug 8639 - vfs_commit is broken (.open_fs doesn't return a file descriptor).
Summary: vfs_commit is broken (.open_fs doesn't return a file descriptor).
Status: RESOLVED FIXED
Alias: None
Product: Samba 3.6
Classification: Unclassified
Component: VFS Modules (show other bugs)
Version: 3.6.1
Hardware: All All
: P5 normal
Target Milestone: ---
Assignee: Karolin Seeger
QA Contact: Samba QA Contact
URL:
Keywords:
Depends on:
Blocks: 8595
  Show dependency tree / graph
 
Reported: 2011-11-30 22:46 UTC by Jeremy Allison
Modified: 2011-12-01 20:03 UTC (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jeremy Allison 2011-11-30 22:46:53 UTC 
Obvious commit by Volker (b638abf70a3c9b2815344454946c0931295551be in master) is needed to return a file descriptor.

This obviously isn't used much but it's not nice to ship obviously broken code :-).

Jeremy.
Comment 1 Jeremy Allison 2011-11-30 22:49:14 UTC 
This commit (b638abf70a3c9b2815344454946c0931295551be) applies cleanly to 3.6.next and 3.5.next.

Count this as a review by a second Team member :-).

Assigning to Karolin for inclusion.
Comment 2 Karolin Seeger 2011-12-01 20:03:59 UTC 
Pushed to v3-5-test and v3-6-test.
Closing out bug report.

Thanks!