Bug 8614 - SMB2: not granting credits for all requests in a compound request
SMB2: not granting credits for all requests in a compound request
Status: RESOLVED FIXED
Product: Samba 3.6
Classification: Unclassified
Component: SMB2
3.6.1
All All
: P5 normal
: ---
Assigned To: Karolin Seeger
Samba QA Contact
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-11-16 13:53 UTC by Christian Ambach
Modified: 2011-11-16 19:32 UTC (History)
1 user (show)

See Also:


Attachments
Jeremy's patch from master (2.00 KB, patch)
2011-11-16 13:53 UTC, Christian Ambach
metze: review+
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Christian Ambach 2011-11-16 13:53:11 UTC
Created attachment 7108 [details]
Jeremy's patch from master

smbd does not grant all credits requested in the individual requests of a compound request instead it only grants the requested credits just for the last request of the compound.
This can lead to a client being left without credits (something that MS-SMB2 requests to avoid)
Comment 1 Stefan Metzmacher 2011-11-16 14:21:16 UTC
Comment on attachment 7108 [details]
Jeremy's patch from master

Looks ok
Comment 2 Stefan Metzmacher 2011-11-16 14:21:41 UTC
Karolin, please pick for the release
Comment 3 Karolin Seeger 2011-11-16 19:32:02 UTC
Pushed to v3-6-test.
Closing out bug report.

Thanks!