Bug 8591 - samr_ChangePasswordUser3 IDL incorrect
Summary: samr_ChangePasswordUser3 IDL incorrect
Alias: None
Product: Samba 3.6
Classification: Unclassified
Component: DCE-RPCs and pipes (show other bugs)
Version: 3.6.1
Hardware: All All
: P5 normal
Target Milestone: ---
Assignee: Guenther Deschner
QA Contact: Samba QA Contact
Depends on:
Reported: 2011-11-09 12:56 UTC by Guenther Deschner
Modified: 2017-04-07 15:35 UTC (History)
1 user (show)

See Also:

v3-6-test.patch (4.85 KB, patch)
2011-11-09 13:00 UTC, Guenther Deschner
metze: review+

Note You need to log in before you can comment on or make changes to this bug.
Description Guenther Deschner 2011-11-09 12:56:32 UTC
samr_ChangePasswordUser3 IDL incorrect
Comment 1 Volker Lendecke 2011-11-09 12:58:12 UTC
Comment 2 Guenther Deschner 2011-11-09 13:00:36 UTC
Created attachment 7073 [details]
Comment 3 Guenther Deschner 2011-11-09 13:01:47 UTC
(In reply to comment #1)

The entire marshalling of samr_ChangePasswordUser3 broke with c2685cdedb430ae75a94e86f34484292b4269363.

The bad effect of this change was that actually all failed password
change attempts in the client path will always return NT_STATUS_OK because the last 4 bytes (the resulting status code) were not marshalled anymore.
Comment 4 Stefan Metzmacher 2011-11-11 01:57:17 UTC
Comment on attachment 7073 [details]

Günther, please ask for updates to MS-SAMR,
as opnum 63 is marked as Opnum63NotUsedOnWire
Comment 5 Stefan Metzmacher 2011-11-11 01:57:52 UTC
Karolin, please pick for the next release
Comment 6 Karolin Seeger 2011-11-14 19:06:45 UTC
Pushed to v3-6-test.
Re-assigning to Günther as a reminder for Metze's request.
Comment 7 Stefan Metzmacher 2012-05-30 18:57:09 UTC
Günther, any updates on this?
Comment 8 Stefan Metzmacher 2017-04-07 15:35:03 UTC
This is fixed with 4.0.0