Bug 8585 - Disconnecting clients swamp the logs
Summary: Disconnecting clients swamp the logs
Alias: None
Product: Samba 3.6
Classification: Unclassified
Component: File services (show other bugs)
Version: 3.6.1
Hardware: All All
: P5 normal
Target Milestone: ---
Assignee: Karolin Seeger
QA Contact: Samba QA Contact
Depends on:
Reported: 2011-11-07 15:10 UTC by Christian Ambach
Modified: 2011-11-09 18:46 UTC (History)
0 users

See Also:

Proposed patch (as in master) (1.19 KB, patch)
2011-11-07 15:12 UTC, Christian Ambach
no flags Details
proposed patch (1.19 KB, patch)
2011-11-07 15:46 UTC, Christian Ambach
vl: review+
proposed patch (1.13 KB, patch)
2011-11-07 15:50 UTC, Christian Ambach
vl: review+

Note You need to log in before you can comment on or make changes to this bug.
Description Christian Ambach 2011-11-07 15:10:48 UTC
This was also reported on the samba mailinglist (https://lists.samba.org/archive/samba/2011-August/163635.html) and makes it hard to read log.smbd in an environment with many clients

[2011/08/09 15:56:18.382148,  1] smbd/process.c:456(receive_smb_talloc)
   read_smb_length_return_keepalive failed for client read 
Comment 1 Christian Ambach 2011-11-07 15:12:17 UTC
Created attachment 7067 [details]
Proposed patch (as in master)
Comment 2 Christian Ambach 2011-11-07 15:46:48 UTC
Created attachment 7068 [details]
proposed patch

in 3.6, we still have client_id around, so do not have go through tsocket and allocate memory
Comment 3 Volker Lendecke 2011-11-07 15:48:53 UTC
Comment on attachment 7068 [details]
proposed patch

I don't really see a difference to the previous patch, but I guess this also works. If the trend is to use more talloce'd memory, so be it.
Comment 4 Christian Ambach 2011-11-07 15:50:47 UTC
Created attachment 7069 [details]
proposed patch

this is the second attempt, previous one was the original patch again
Comment 5 Christian Ambach 2011-11-07 16:12:41 UTC

please pick for the next release
Comment 6 Karolin Seeger 2011-11-09 18:46:47 UTC
Pushed to v3-6-test.
Closing out bug report.