Bug 8520 - Fix SMB2 SMB2_OP_GETINFO and SMB2_OP_IOCTL parsing requirements.
Summary: Fix SMB2 SMB2_OP_GETINFO and SMB2_OP_IOCTL parsing requirements.
Status: RESOLVED FIXED
Alias: None
Product: Samba 3.6
Classification: Unclassified
Component: SMB2 (show other bugs)
Version: unspecified
Hardware: All All
: P5 normal
Target Milestone: ---
Assignee: Karolin Seeger
QA Contact: Samba QA Contact
URL:
Keywords:
Depends on:
Blocks: 8399
  Show dependency tree / graph
 
Reported: 2011-10-11 20:01 UTC by Jeremy Allison
Modified: 2011-10-12 18:51 UTC (History)
1 user (show)

See Also:

Attachments
git-am patchset for 3.6.1 (42.43 KB, patch)
2011-10-11 20:07 UTC, Jeremy Allison 		metze: review+
ddiss: review+
Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jeremy Allison 2011-10-11 20:01:42 UTC 
This is a raft of patches that are back-ported from master that bring the 3.6.1 SMB2 code closer to the master tree and include some minor bug fixes.

I'd like to get them into 3.6.1 to minimize the differences between the trees for backporting fixes.

Jeremy.
Comment 1 Jeremy Allison 2011-10-11 20:07:43 UTC 
Created attachment 6986 [details]
git-am patchset for 3.6.1

This is the following set of patches back-ported to 3.6.1 from metze and David Disseldorp.

s3:smb2_server: add smbd_smb2_request_verify_sizes()
s3:smb2_server: use smbd_smb2_request_verify_sizes() in smb2_negprot.c
s3:smb2_server: use smbd_smb2_request_verify_sizes() in smb2_sesssetup.c
s3:smb2_server: use smbd_smb2_request_verify_sizes() in smb2_tcon.c
s3:smb2_server: use smbd_smb2_request_verify_sizes() in smb2_break.c
s3:smb2_server: use smbd_smb2_request_verify_sizes() in smb2_close.c
s3:smb2_server: use smbd_smb2_request_verify_sizes() in smb2_create.c
s3:smb2_server: use smbd_smb2_request_verify_sizes() in smb2_find.c
s3:smb2_server: use smbd_smb2_request_verify_sizes() in smb2_flush.c
s3:smb2_server: use smbd_smb2_request_verify_sizes() in smb2_getinfo.c
s3:smb2_server: use smbd_smb2_request_verify_sizes() in smb2_ioctl.c
s3:smb2_server: use smbd_smb2_request_verify_sizes() in smb2_keepalive.c
s3:smb2_server: use smbd_smb2_request_verify_sizes() in smb2_lock.c
s3:smb2_server: use smbd_smb2_request_verify_sizes() in smb2_notify.c
s3:smb2_server: use smbd_smb2_request_verify_sizes() in smb2_read.c
s3:smb2_server: use smbd_smb2_request_verify_sizes() in smb2_setinfo.c
s3:smb2_server: use smbd_smb2_request_verify_sizes() in smb2_write.c
s3:smb2_server: return BAD_NETWORK_NAME if the path is terminated in SMB2_TCON
s3:smb2_server: return OBJECT_NAME_INVALID if the path is terminated in SMB2_CREATE
s3:smb2_server: return OBJECT_NAME_INVALID if the path is terminated in SMB2_FIND/QUERY_DIRECTORY
s3:smb2_server: SMB2_OP_GETINFO doesn't require at least 1 dyn byte
s3-smb2_server: SMB2_OP_IOCTL doesn't require at least 1 dyn byte
s3-smb2_server: fix ioctl InputOffset checking
Comment 2 Stefan Metzmacher 2011-10-12 10:05:01 UTC 
Comment on attachment 6986 [details]
git-am patchset for 3.6.1

Looks good
Comment 3 Stefan Metzmacher 2011-10-12 10:05:25 UTC 
Karolin, please pick for the release
Comment 4 Karolin Seeger 2011-10-12 18:51:40 UTC 
Pushed to v3-6-test.
Closing out bug report.

Thanks!