The Samba-Bugzilla – Bug 8395
optimize serverid_exists() for Solaris.
Last modified: 2011-08-25 16:35:22 UTC
Ira Cooper <firstname.lastname@example.org> reports:
Problem: Samba is being existential. It is wondering if it exists far too
much, especially when it can just poke itself and see.
As far as how often it does this check: I've seen it be over 50% of the calls
to this function. Given the price of the calls involved, seems like a cheap
Do you have any idea on how many calls it saves,
and what help the optimization gives ?
As far as calls: Not 100% sure, dtrace pointed the issue out to me, and when I
saw 10-50%(Or more), I looked for an easy fix.
The real expense here is the fnctl locks on the database. That's pretty
painful. 1000ns per call, and probably 3-4 calls in that chain. So it doesn't
take much to come out ahead was my math.
Created attachment 6799 [details]
git-am fix for 3.6.1
Volker, please review for 3.6.1.
Pushed to v3-6-test.
Closing out bug report.