Bug 8368 - "idmap config * : script" has wrong default, and the "idmap:script" fallback does not work
Summary: "idmap config * : script" has wrong default, and the "idmap:script" fallback ...
Status: RESOLVED FIXED
Alias: None
Product: Samba 3.6
Classification: Unclassified
Component: Winbind (show other bugs)
Version: 3.6.0
Hardware: All All
: P5 normal
Target Milestone: ---
Assignee: Karolin Seeger
QA Contact: Samba QA Contact
URL:
Keywords:
Depends on:
Blocks: 8399
  Show dependency tree / graph
 
Reported: 2011-08-10 11:39 UTC by Michael Adam
Modified: 2011-08-25 16:35 UTC (History)
1 user (show)

See Also:

Attachments
patch for 3.6 (978 bytes, patch)
2011-08-10 11:46 UTC, Michael Adam 		vl: review+
Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Adam 2011-08-10 11:39:46 UTC 
For 3.6.0, the idmap:script parameter (which belongs to the tdb2 idmap backend) was deprecated in favour of the more systematic "idmap config * : script".

There is a bug in the code change though, which defaults the "idmap config * : script" to "NULL" (string) instead of NULL (null pointer).

This lets the fallback to the idmap:script parameter fail.
It also leads to vain attempts to call out to a script called "NULL" when unmapped sids are found.

Michael
Comment 1 Michael Adam 2011-08-10 11:46:02 UTC 
Created attachment 6770 [details]
patch for 3.6

This patch for 3.6 is currently in autobuild for master.
Comment 2 Michael Adam 2011-08-10 13:31:06 UTC 
Thanks.
Assigning to Karolin for 3.6.1.
Comment 3 Karolin Seeger 2011-08-18 19:02:03 UTC 
Pushed to v3-6-test.
Closing out bug report.

Thanks!