Bug 834 - NT error codes are ALWAYS returned
Summary: NT error codes are ALWAYS returned
Status: CLOSED FIXED
Alias: None
Product: Samba 3.0
Classification: Unclassified
Component: File Services (show other bugs)
Version: 3.0.0
Hardware: All Linux
: P3 normal
Target Milestone: none
Assignee: Jeremy Allison
QA Contact:
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2003-11-28 03:25 UTC by John Kleven
Modified: 2005-11-14 09:27 UTC (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description John Kleven 2003-11-28 03:25:05 UTC 
NT error/status codes are returned from the smbd server (3.0.0) even when my
client sets that flags2 in all packets to "DOS error codes" and my capabilities
32 bit int in the session setup packet also says that NT error codes are NOT
supported.

Don't follow the development closely so maybe this is as designed -- but it
seems like it could be considered a protocol violation.  

Thanks 
John

x86 (Pentium III)
RedHat 9.0
smbd version is 3.0.0
Comment 1 John Kleven 2003-11-28 13:21:16 UTC 
Here's an email i sent w/ to samba-technical w/ more information regarding the
problem:

Samba 3.0.0 bug possible - wanted to get any input from developers:

When i attach to smbd version 3.0.0 i specify in all my client packets (via
flags2 arg) that i do NOT understand NT style error codes.

Also, in my capabilities 32 bit int sent in session setup packet -- I say that i
do not speak NT style error codes.

But Samba 3.0.0 continues to send me NT codes for the packets that i send.

Here's the catch -- if the request to the smbd server is succesful (i.e. a
session setup login packet to server) it sends me the NT success code (i.e.
flags2 says that error codes are NT style).  BUT... when a request fails, it
DOES send me the DOS error code like it should.

I think it is a bug however that smbd 3.0.0 flags2 arg to specify "NT error
codes" in succesful client requests.  If the client capabilities indicated that
it does not understand NT error codes, it should never send another flags2 arg
with NT status codes enabled.

Right??  This is now in the bug database as bug #834.

Thanks
John
Comment 2 Jeremy Allison 2003-11-30 23:02:55 UTC 
Fixed in CVS (SAMBA_3_0 and HEAD). Default to NT status codes, but turn off flag
if client says it doesn't support them in sessionsetupandX.
Jeremy.
Comment 3 Gerald (Jerry) Carter (dead mail address) 2005-08-24 10:23:40 UTC 
sorry for the same, cleaning up the database to prevent unecessary reopens of bugs.
Comment 4 Gerald (Jerry) Carter (dead mail address) 2005-11-14 09:27:42 UTC 
database cleanup