Bug 8328 - final cleanup of idmap_tdb2 code and docs needed for release
final cleanup of idmap_tdb2 code and docs needed for release
Status: RESOLVED FIXED
Product: Samba 3.6
Classification: Unclassified
Component: Winbind
3.6.0rc3
All All
: P5 normal
: ---
Assigned To: Karolin Seeger
Samba QA Contact
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-07-27 07:56 UTC by Michael Adam
Modified: 2012-05-23 20:01 UTC (History)
2 users (show)

See Also:


Attachments
Patcheset for v3-6-test (12.85 KB, patch)
2011-07-27 07:56 UTC, Michael Adam
obnox: review+
vl: review+
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Adam 2011-07-27 07:56:22 UTC
Created attachment 6720 [details]
Patcheset for v3-6-test

In the rewrite of idmapping, I missed a few minor things for idmap_tdb2:

(1)  There is an old, undocumented option with the silly name "tdb:idmap2.tdb" which I have never seen used and which is completely poinltess since ctdb supports persistent databases (i.e. since ages).

(2) The "idmap:script" option does not match the rewritten systematic configuration. This should be "idmap config * : script" (or more general "idmap congfig DOMAIN : script").

Attached find a patchset for 3.6, already pushed to master, that fixes the two by (1) removing the "tdb:idmap2.tdb" parameter and by (2) deprecating "idmap:script" in favour of "idmap config * : script" keeping the old one as a fallback. Additionally, the patches fix a couple of legacy code comments and adapt the idmap_tdb2 manpage to be more correct and reflect the new configuration.

Cheers - Michael
Comment 1 Michael Adam 2011-07-27 07:56:49 UTC
Comment on attachment 6720 [details]
Patcheset for v3-6-test

Patchset for 3.6.
Ambi: please review...
Comment 2 Michael Adam 2011-07-27 09:49:28 UTC
==> karolin
Comment 3 Karolin Seeger 2011-07-27 18:08:37 UTC
IMHO it's way too late in the release process for cleanups, but taking it for 3.6.1 would not make sense.

Pushed to v3-6-test and praying that we don't need rc4...
Closing out bug report.