Bug 8304 - Uninitialized variable referenced in error path.
Summary: Uninitialized variable referenced in error path.
Status: RESOLVED FIXED
Alias: None
Product: Samba 3.6
Classification: Unclassified
Component: DCE-RPCs and pipes (show other bugs)
Version: unspecified
Hardware: All All
: P5 normal
Target Milestone: ---
Assignee: Karolin Seeger
QA Contact: Samba QA Contact
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-07-12 19:56 UTC by Jeremy Allison
Modified: 2011-07-13 18:52 UTC (History)
2 users (show)

See Also:

Attachments
git-am fix for 3.6.0 (1.20 KB, patch)
2011-07-12 20:09 UTC, Jeremy Allison 		jra: review? (abartlet)
metze: review+
Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jeremy Allison 2011-07-12 19:56:46 UTC 
In the current v3-6-test build (Jul12th) I get:

Compiling rpc_server/dcesrv_gssapi.c
rpc_server/dcesrv_gssapi.c: In function ‘gssapi_server_get_user_info’:
rpc_server/dcesrv_gssapi.c:108: warning: unused variable ‘auth_data’
rpc_server/dcesrv_gssapi.c:147: warning: ‘princ_name’ may be used uninitialized in this function

The second warning is correct, princ_name is an uninitialized variable that is referenced in the error path if the PAC data is pulled incorrectly.

Patch for both to follow.

Jeremy.
Comment 1 Jeremy Allison 2011-07-12 20:09:11 UTC 
Created attachment 6695 [details]
git-am fix for 3.6.0

Andrew, this looks like a change introduced with the gse code. Can you review asap and make a decision if this needs to be in 3.6.0rc3 or can wait until 3.6.1.

Thanks,

Jeremy.
Comment 2 Jeremy Allison 2011-07-12 20:10:57 UTC 
One more comment - princ is not just referenced in an error path, it's actually used unconditionally in the call to get_user_from_kerberos_info() inside gssapi_server_get_user_info() so this is more urgent that merely an error code path.

Jeremy.
Comment 3 Jeremy Allison 2011-07-12 20:15:16 UTC 
Comment on attachment 6695 [details]
git-am fix for 3.6.0

Metze if you could review and make a decision on this before rc3 that would also help (a lot).

Thanks :-).

Jeremy.
Comment 4 Stefan Metzmacher 2011-07-12 20:29:47 UTC 
Comment on attachment 6695 [details]
git-am fix for 3.6.0

Looks ok
Comment 5 Stefan Metzmacher 2011-07-12 20:30:31 UTC 
Karolin, please pick for rc3.
Comment 6 Karolin Seeger 2011-07-13 18:52:27 UTC 
Pushed to v3-6-test.
Closing out bug report.

Thanks!