Bug 8293 - SMB2 doesn't rotate the log files often enough.
Summary: SMB2 doesn't rotate the log files often enough.
Status: RESOLVED FIXED
Alias: None
Product: Samba 3.6
Classification: Unclassified
Component: SMB2 (show other bugs)
Version: unspecified
Hardware: All All
: P5 normal
Target Milestone: ---
Assignee: Stefan Metzmacher
QA Contact: Samba QA Contact
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-07-07 21:59 UTC by Jeremy Allison
Modified: 2011-07-16 06:42 UTC (History)
2 users (show)

See Also:

Attachments
git-am fix for 3.6.0 (2.84 KB, patch)
2011-07-07 22:37 UTC, Jeremy Allison 		metze: review+
Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jeremy Allison 2011-07-07 21:59:23 UTC 
The SMB2 code path is missing the check in the SMB1 code path that will rotate log files every 50 incoming requests. This can cause large log file size overrun.

Patch to follow.

Jeremy.
Comment 1 Jeremy Allison 2011-07-07 22:37:50 UTC 
Created attachment 6673 [details]
git-am fix for 3.6.0

Metze & Karolin, I'm ok with this going into 3.6.1.

Jeremy.
Comment 2 Stefan Metzmacher 2011-07-11 19:44:01 UTC 
Comment on attachment 6673 [details]
git-am fix for 3.6.0

Looks ok
Comment 3 Stefan Metzmacher 2011-07-11 19:44:33 UTC 
Karolin, please pick for the next rc
Comment 4 Karolin Seeger 2011-07-12 19:08:22 UTC 
Pushed to v3-6-test.
Closing out bug report.

Thanks!
Comment 5 Karolin Seeger 2011-07-15 19:21:35 UTC 
Re-assigning to Metze as he re-opened the bug report.
Comment 6 Stefan Metzmacher 2011-07-16 06:42:58 UTC 
Reopening was not intended