The Samba-Bugzilla – Bug 8284
hfs-compression.diff patch incorrectly expands relative directory
Last modified: 2011-07-04 22:35:13 UTC
There is a bug when using a relative path for the destination with the hfs-compression.diff patch and --hfs-compression option. (Note that this bug is not present with the --protect-decmpfs option)
The Destination: $HOME/Desktop/Untitledfolder2 works as expected, however if, from my Home Directory I use Desktop/Untitledfolder2, the relative path Desktop/Untitledfolder2 is incorrectly expanded to "/Users/Tony/Desktop/Untitledfolder2/Desktop/Untitledfolder2"
/usr/local/bin/rsync -aNHAXv --hfs-compression --fileflags --force-change --delete Desktop/Untitledfolder1/ Desktop/Untitledfolder2
sending incremental file list
rsync: statfs "/Users/Tony/Desktop/Untitledfolder2/Desktop/Untitledfolder2" failed: No such file or directory (2)
rsync error: errors selecting input/output files, dirs (code 3) at main.c(514) [Receiver=3.0.8]
rsync: connection unexpectedly closed (9 bytes received so far) [sender]
rsync error: error in rsync protocol data stream (code 12) at io.c(601) [sender=3.0.8]
Looks like hfs_receiver_check() should always test ".", not try to test dest_path (since the caller already did a chdir to dest_path). Fix committed.