Bug 8281 - examples/VFS/* does not build
Summary: examples/VFS/* does not build
Status: RESOLVED FIXED
Alias: None
Product: Samba 3.6
Classification: Unclassified
Component: VFS Modules (show other bugs)
Version: unspecified
Hardware: All All
: P5 normal
Target Milestone: ---
Assignee: Karolin Seeger
QA Contact: Samba QA Contact
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-07-01 10:23 UTC by Björn Baumbach
Modified: 2011-07-04 19:38 UTC (History)
0 users

See Also:

Attachments
bug fix (5.35 KB, patch)
2011-07-01 10:23 UTC, Björn Baumbach 		bjacke: review+
obnox: review-
Details
updated patchset without talloc/TALLOC clutter (4.21 KB, patch)
2011-07-01 10:57 UTC, Michael Adam 		bjacke: review+
Details
patch to always build vfs examples in "make everything" (1.59 KB, patch)
2011-07-01 11:01 UTC, Michael Adam 		bjacke: review+
Details
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Björn Baumbach 2011-07-01 10:23:32 UTC 
Created attachment 6658 [details]
bug fix
Comment 1 Björn Jacke 2011-07-01 10:31:19 UTC 
Comment on attachment 6658 [details]
bug fix

looks good, Karolin please pick the build fix in 3.6
Comment 2 Michael Adam 2011-07-01 10:53:51 UTC 
Comment on attachment 6658 [details]
bug fix

this patchseet is buggy:
some error has been introduced while cherry-picking from master.
(talloc vs. TALLOC mixup)
Comment 3 Michael Adam 2011-07-01 10:54:15 UTC 
updated patchset coming soon...
Comment 4 Michael Adam 2011-07-01 10:57:05 UTC 
Created attachment 6659 [details]
updated patchset without talloc/TALLOC clutter

This is the same patchset but w/o the conflict resolution clutter (talloc/TALLOC)... In particular the additional "prepare..." patch is not necessary :-)
Comment 5 Michael Adam 2011-07-01 10:58:13 UTC 
Comment on attachment 6659 [details]
updated patchset without talloc/TALLOC clutter

Björn, please review again... :-)
Comment 6 Michael Adam 2011-07-01 11:01:16 UTC 
Created attachment 6660 [details]
patch to always build vfs examples in "make everything"

This additional patch from master lets "make everything" build the vfs examples.
Should we add it to 3.6 for completeness?
Comment 7 Björn Jacke 2011-07-01 21:51:59 UTC 
(In reply to comment #6)
> This additional patch from master lets "make everything" build the vfs
> examples.
> Should we add it to 3.6 for completeness?

I'd say +1 but Karolin shall decide it.
Comment 8 Karolin Seeger 2011-07-04 19:38:50 UTC 
Pushed both patch sets to v3-6-test.
Closing out bug report.

Thanks!