Bug 8268 - Wrong unchanged_attrs test for symlink ownership
Wrong unchanged_attrs test for symlink ownership
Status: RESOLVED FIXED
Product: rsync
Classification: Unclassified
Component: core
3.1.0
All All
: P5 normal
: ---
Assigned To: Wayne Davison
Rsync QA Contact
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-06-25 22:26 UTC by Matt McCutchen
Modified: 2011-07-04 21:43 UTC (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Matt McCutchen 2011-06-25 22:26:05 UTC
From unchanged_attrs:

#ifdef CAN_CHMOD_SYMLINK
		if (perms_differ(file, sxp))
			return 0;
#endif
#ifndef CAN_CHOWN_SYMLINK
		if (ownership_differs(file, sxp))
			return 0;
#endif

Seems like the #ifndef should be another #ifdef.
Comment 1 Wayne Davison 2011-07-04 21:43:34 UTC
Thanks!  I checked in a fix for this.