Bug 8230 - Move .nmbd socket directory to non-hidden name PREFIX/var/nmbd
Move .nmbd socket directory to non-hidden name PREFIX/var/nmbd
Status: RESOLVED FIXED
Product: Samba 3.6
Classification: Unclassified
Component: Build environment
3.6.0rc2
All All
: P5 regression
: ---
Assigned To: Björn Jacke
Samba QA Contact
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-06-14 05:18 UTC by Andrew Bartlett
Modified: 2011-06-24 19:38 UTC (History)
0 users

See Also:


Attachments
Move nmbd socket directory to PREFX/var/nmbd (1.29 KB, patch)
2011-06-14 05:18 UTC, Andrew Bartlett
no flags Details
Show location of nmbd and ncalrpc socket dirs in 'smbd -b' (942 bytes, patch)
2011-06-14 05:19 UTC, Andrew Bartlett
vl: review+
Details
Move nmbd socket directory to PREFX/var/nmbd (1.34 KB, patch)
2011-06-14 05:27 UTC, Andrew Bartlett
vl: review+
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Andrew Bartlett 2011-06-14 05:18:04 UTC
Created attachment 6576 [details]
Move nmbd socket directory to PREFX/var/nmbd

This patch moves the .nmbd socket directory to a non-hidden name, matching the pattern of the ncalrpc directory also being added in the 3.6 release.  As this directory is no longer in /tmp (an early proposal), it does not need to be hidden. 

The second patch demonstrates the ncalrpc dir and nmbd dir in 'smbd -b'.
Comment 1 Andrew Bartlett 2011-06-14 05:19:07 UTC
Created attachment 6577 [details]
Show location of nmbd and ncalrpc socket dirs in 'smbd -b'

This helps show that the directory names are now consistent, and assists debugging of the 3.6 release tree.
Comment 2 Andrew Bartlett 2011-06-14 05:20:53 UTC
Comment on attachment 6576 [details]
Move nmbd socket directory to PREFX/var/nmbd

Volker,

This directory is your baby, so I'll ask you to review the idea of moving it for the 3.6 release. 

Sorry for the late patch (I was reviewing filesystem paths in master and came across this).  I think this location is more consistent with the ncalrpc directory.
Comment 3 Andrew Bartlett 2011-06-14 05:27:38 UTC
Created attachment 6578 [details]
Move nmbd socket directory to PREFX/var/nmbd

Re-attach with tridge's sign-off.
Comment 4 Volker Lendecke 2011-06-14 05:45:20 UTC
Why this change? I modeled it after the /tmp/.winbindd directory, so we are kindof inconsistent anyway. Please give a good reason why this must be changed now or in the future.

Thanks,

Volker
Comment 5 Karolin Seeger 2011-06-24 19:38:05 UTC
Pushed both patches to v3-6-test.
Please note that I asked for opinions on the mailing list and nobody raised any concerns on the list.
If there are any objections, please contact me asap.

Closing out bug report.

Thanks!