Bug 8224 - source3/smbd/quotas.c fails to build on freebsd
Summary: source3/smbd/quotas.c fails to build on freebsd
Status: RESOLVED FIXED
Alias: None
Product: Samba 3.6
Classification: Unclassified
Component: Build environment (show other bugs)
Version: 3.6.0rc2
Hardware: All FreeBSD
: P5 normal
Target Milestone: ---
Assignee: Karolin Seeger
QA Contact: Samba QA Contact
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-06-13 18:06 UTC by Herb Lewis
Modified: 2011-06-15 10:23 UTC (History)
1 user (show)

See Also:
bjacke: review+

Attachments
proposed fix (322 bytes, patch)
2011-06-13 18:06 UTC, Herb Lewis 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Herb Lewis 2011-06-13 18:06:09 UTC 
Created attachment 6572 [details]
proposed fix

MNT_NOWAIT is defined in sys/mount.h which was not being included
Comment 1 Stefan Metzmacher 2011-06-14 09:02:21 UTC 
I've pushed a more generic fix to master
8096b1a9a4b1518467e7a85bb9000904a76c1ac4

This needs to be picked to v3-6-test. Björn please review.
Comment 2 Björn Jacke 2011-06-14 09:22:20 UTC 
8096b1a9a4b1518467e7a85bb9000904a76c1ac4 looks good.

Karolin, please pick that to 3.6 to fix the FreeBSD.
Comment 3 Karolin Seeger 2011-06-14 18:11:04 UTC 
Pushed to v3-6-test.
Closing out bug report.

Thanks!
Comment 4 Herb Lewis 2011-06-14 21:22:19 UTC 
Only problem with this fix is that sys/filesys.h does not exist on my freebsd
system.
Comment 5 Stefan Metzmacher 2011-06-15 00:14:05 UTC 
It's v3-6-test:lib/replace/system/filesys.h not <sys/filesys.h> from /usr/include.

lib/replace/system/filesys.h should trigger the #include <sys/mount.h>
if available.