Bug 8154 - Actually make use of SMBTA subversion numbers
Summary: Actually make use of SMBTA subversion numbers
Status: RESOLVED FIXED
Alias: None
Product: Samba 3.6
Classification: Unclassified
Component: VFS Modules (show other bugs)
Version: 3.6.0rc1
Hardware: All All
: P5 normal
Target Milestone: ---
Assignee: Karolin Seeger
QA Contact: Samba QA Contact
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-05-19 20:18 UTC by Holger Hetterich
Modified: 2011-05-26 18:17 UTC (History)
1 user (show)

See Also:

Attachments
Patch against master and 3.6.0 (1.87 KB, patch)
2011-05-19 20:19 UTC, Holger Hetterich 		jra: review+
Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Holger Hetterich 2011-05-19 20:18:36 UTC 
This patch was posted by me on 20.02.2011 on technical, but it seems no one has looked at it for review. I have to blame myself that I did not pinged for it in the meantime.

Here is the original message:
"
Attached is a patch to

actually make use of the SMBTA_SUBRELEASE define in
smb_traffic_analyzer.h. This will allow to introduce
new features or fixes into the protocol after the 3.6.0
release. The client software is designed to take care
for the subrelease number.

Please review and commit if it's fine,
Thank you,
Holger"

I've attached the patch to this comment.

This will allow to extend the protocol in 3.6.x versions of Samba in a controlled way. I would like to get this into master and 3.6.0.
Comment 1 Holger Hetterich 2011-05-19 20:19:30 UTC 
Created attachment 6458 [details]
Patch against master and 3.6.0

Patch for 3.6.0 and master
Comment 2 Jeremy Allison 2011-05-24 17:10:20 UTC 
Comment on attachment 6458 [details]
Patch against master and 3.6.0

Looks good to me - thanks Holger.
Comment 3 Jeremy Allison 2011-05-24 17:15:15 UTC 
Re-assigning to Karolin for inclusion in 3.6.0.

Jeremy.
Comment 4 Karolin Seeger 2011-05-26 18:17:21 UTC 
Pushed to v3-6-test.
Closing out bug report.

Thanks!