Bug 8137 - Use a union instead of storing an integer in idlist::name
Summary: Use a union instead of storing an integer in idlist::name
Status: RESOLVED FIXED
Alias: None
Product: rsync
Classification: Unclassified
Component: core (show other bugs)
Version: 3.1.0
Hardware: All All
: P5 normal (vote)
Target Milestone: ---
Assignee: Wayne Davison
QA Contact: Rsync QA Contact
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-05-16 18:52 UTC by Matt McCutchen
Modified: 2011-05-17 01:24 UTC (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Matt McCutchen 2011-05-16 18:52:26 UTC 
The idlist code is stuffing an integer in the idlist::name member, which causes a compiler warning:

uidlist.c: In function ‘parse_name_map’:
uidlist.c:466:12: warning: cast to pointer from integer of different size

The code should use a union instead.
Comment 1 Wayne Davison 2011-05-17 01:24:48 UTC 
I checked in a fix for this.