Bug 8128 - Fails to build against system versions of embedded libraries (WAF dependencies)
Fails to build against system versions of embedded libraries (WAF dependencies)
Status: RESOLVED FIXED
Product: Samba 4.0
Classification: Unclassified
Component: Build
unspecified
All All
: P5 normal
: ---
Assigned To: Andrew Tridgell
samba4-qa@samba.org
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-05-10 08:46 UTC by Sean Finney
Modified: 2011-05-25 16:03 UTC (History)
1 user (show)

See Also:


Attachments
Proposed patch (34.49 KB, patch)
2011-05-20 13:37 UTC, Sean Finney
no flags Details
Proposed patch [v2] (34.87 KB, patch)
2011-05-25 08:15 UTC, Sean Finney
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Sean Finney 2011-05-10 08:46:14 UTC
Building from latest master (0d93eb8):

WAF_MAKE=1 ./buildtools/bin/waf build
Waf: Entering directory `/home/CORPUSERS/23059934/gnome3/samba4/bin'
[  76/3265] Generating VERSION
[2241/3265] Compiling libgpo/gpo_ldap.c
In file included from ../source3/../lib/util/util.h:24,
                 from ../source3/include/includes.h:506,
                 from ../libgpo/gpo_ldap.c:20:
../lib/util/charset/charset.h:28:20: error: talloc.h: No such file or directory
In file included from ../source3/../lib/util/util.h:24,
                 from ../source3/include/includes.h:506,
                 from ../libgpo/gpo_ldap.c:20:
../lib/util/charset/charset.h:135: error: expected ')' before '*' token
../lib/util/charset/charset.h:136: error: expected ')' before '*' token
../lib/util/charset/charset.h:138: error: expected declaration specifiers or '...' before 'TALLOC_CTX'
../lib/util/charset/charset.h:139: error: expected ')' before '*' token
../lib/util/charset/charset.h:141: error: expected declaration specifiers or '...' before 'TALLOC_CTX'
../lib/util/charset/charset.h:142: error: expected ')' before '*' token
../lib/util/charset/charset.h:153: error: expected ')' before '*' token
../lib/util/charset/charset.h:154: error: expected ')' before '*' token
../lib/util/charset/charset.h:155: error: expected ')' before '*' token
../lib/util/charset/charset.h:156: error: expected ')' before '*' token
../lib/util/charset/charset.h:157: error: expected ')' before '*' token
../lib/util/charset/charset.h:158: error: expected ')' before '*' token
../lib/util/charset/charset.h:162: error: expected ')' before '*' token
../lib/util/charset/charset.h:176: error: expected ')' before '*' token
../lib/util/charset/charset.h:183: error: expected ')' before '*' token
../lib/util/charset/charset.h:212: error: expected ')' before '*' token
../lib/util/charset/charset.h:229: error: expected ')' before '*' token
../lib/util/charset/charset.h:240: error: expected ')' before '*' token
In file included from ../source3/../lib/util/util.h:39,
                 from ../source3/include/includes.h:506,
                 from ../libgpo/gpo_ldap.c:20:
../lib/util/time.h:127: error: expected ')' before '*' token
../lib/util/time.h:134: error: expected ')' before '*' token
../lib/util/time.h:139: error: expected ')' before '*' token
../lib/util/time.h:146: error: expected ')' before '*' token
../lib/util/time.h:151: error: expected ')' before '*' token
In file included from ../source3/../lib/util/util.h:40,
                 from ../source3/include/includes.h:506,
                 from ../libgpo/gpo_ldap.c:20:
../lib/util/data_blob.h:61: error: expected ')' before '*' token
../lib/util/data_blob.h:68: error: expected ')' before '*' token
../lib/util/data_blob.h:93: error: expected ')' before '*' token
../lib/util/data_blob.h:98: error: expected ')' before '*' token
../lib/util/data_blob.h:122: error: expected ')' before '*' token
../lib/util/data_blob.h:127: error: expected ')' before '*' token
In file included from ../source3/../lib/util/util.h:43,
                 from ../source3/include/includes.h:506,
                 from ../libgpo/gpo_ldap.c:20:
../lib/util/talloc_stack.h:47: error: expected '=', ',', ';', 'asm' or '__attribute__' before '*' token
../lib/util/talloc_stack.h:48: error: expected '=', ',', ';', 'asm' or '__attribute__' before '*' token
../lib/util/talloc_stack.h:54: error: expected '=', ',', ';', 'asm' or '__attribute__' before '*' token
In file included from ../source3/include/includes.h:506,
                 from ../libgpo/gpo_ldap.c:20:
../source3/../lib/util/util.h:186: error: expected ')' before '*' token
../source3/../lib/util/util.h:191: error: expected ')' before '*' token
../source3/../lib/util/util.h:199: error: expected ')' before '*' token
../source3/../lib/util/util.h:208: error: expected ')' before '*' token
../source3/../lib/util/util.h:223: error: expected ')' before '*' token
../source3/../lib/util/util.h:233: error: expected ')' before '*' token
../source3/../lib/util/util.h:264: error: expected ')' before '*' token
../source3/../lib/util/util.h:274: error: expected ')' before '*' token
../source3/../lib/util/util.h:292: error: expected ')' before '*' token
../source3/../lib/util/util.h:314: error: expected ')' before '*' token
../source3/../lib/util/util.h:322: error: expected ')' before '*' token
../source3/../lib/util/util.h:331: error: expected ')' before '*' token
../source3/../lib/util/util.h:337: error: expected ')' before '*' token
../source3/../lib/util/util.h:345: error: expected ')' before '*' token
../source3/../lib/util/util.h:425: error: expected ')' before '*' token
../source3/../lib/util/util.h:444: error: expected ')' before '*' token
../source3/../lib/util/util.h:449: error: expected ')' before '*' token
../source3/../lib/util/util.h:457: error: expected ')' before '*' token
../source3/../lib/util/util.h:465: error: expected ')' before '*' token
../source3/../lib/util/util.h:470: error: expected ')' before '*' token
../source3/../lib/util/util.h:474: error: expected ')' before '*' token
../source3/../lib/util/util.h:484: error: expected ')' before '*' token
../source3/../lib/util/util.h:544: error: expected ')' before '*' token
../source3/../lib/util/util.h:566: error: expected declaration specifiers or '...' before 'TALLOC_CTX'
../source3/../lib/util/util.h:571: error: expected declaration specifiers or '...' before 'TALLOC_CTX'
../source3/../lib/util/util.h:574: error: expected declaration specifiers or '...' before 'TALLOC_CTX'
../source3/../lib/util/util.h:579: error: expected declaration specifiers or '...' before 'TALLOC_CTX'
../source3/../lib/util/util.h:590: error: expected declaration specifiers or '...' before 'TALLOC_CTX'
../source3/../lib/util/util.h:597: error: expected declaration specifiers or '...' before 'TALLOC_CTX'
../source3/../lib/util/util.h:667: error: expected ')' before '*' token
../source3/../lib/util/util.h:795: error: expected ')' before '*' token
../source3/../lib/util/util.h:858: error: expected ')' before '*' token
../source3/../lib/util/util.h:860: error: expected ')' before '*' token
../source3/../lib/util/util.h:880: error: expected ')' before '*' token
In file included from ../source3/include/includes.h:507,
                 from ../libgpo/gpo_ldap.c:20:
../source3/../lib/util/util_net.h:105: error: expected ')' before '*' token
In file included from ../source3/include/includes.h:516,
                 from ../libgpo/gpo_ldap.c:20:
../source3/include/event.h:22:20: error: tevent.h: No such file or directory
In file included from ../source3/include/includes.h:516,
                 from ../libgpo/gpo_ldap.c:20:
../source3/include/event.h:30: warning: 'struct event_context' declared inside parameter list
../source3/include/event.h:30: warning: its scope is only this definition or declaration, which is probably not what you want
../source3/include/event.h:31: warning: 'struct event_context' declared inside parameter list
../source3/include/event.h:32: error: expected ')' before '*' token
../source3/include/event.h:34: error: expected declaration specifiers or '...' before 'TALLOC_CTX'
In file included from ../libcli/smb/smb_common.h:26,
                 from ../source3/include/smb.h:29,
                 from ../source3/include/includes.h:529,
                 from ../libgpo/gpo_ldap.c:20:
../source3/../libcli/smb/smb2_create_blob.h:39: error: expected ')' before '*' token
../source3/../libcli/smb/smb2_create_blob.h:45: error: expected ')' before '*' token
../source3/../libcli/smb/smb2_create_blob.h:48: error: expected ')' before '*' token
In file included from ../libcli/smb/smb_common.h:28,
                 from ../source3/include/smb.h:29,
                 from ../source3/include/includes.h:529,
                 from ../libgpo/gpo_ldap.c:20:
../source3/../libcli/smb/smb_util.h:22: error: expected ')' before '*' token
In file included from ../source3/include/smb.h:317,
                 from ../source3/include/includes.h:529,
                 from ../libgpo/gpo_ldap.c:20:
../source3/include/ntquotas.h:80: error: expected specifier-qualifier-list before 'TALLOC_CTX'
In file included from ../source3/include/smb.h:384,
                 from ../source3/include/includes.h:529,
                 from ../libgpo/gpo_ldap.c:20:
../source3/include/vfs.h:287: error: expected declaration specifiers or '...' before 'TALLOC_CTX'
../source3/include/vfs.h:294: error: expected declaration specifiers or '...' before 'TALLOC_CTX'
../source3/include/vfs.h:327: error: expected declaration specifiers or '...' before 'TALLOC_CTX'
In file included from ../source3/include/smb.h:384,
                 from ../source3/include/includes.h:529,
                 from ../libgpo/gpo_ldap.c:20:
../source3/include/vfs.h:661: error: expected declaration specifiers or '...' before 'TALLOC_CTX'
../source3/include/vfs.h:666: error: expected declaration specifiers or '...' before 'TALLOC_CTX'
../source3/include/vfs.h:691: error: expected declaration specifiers or '...' before 'TALLOC_CTX'
In file included from ../source3/include/includes.h:539,
                 from ../libgpo/gpo_ldap.c:20:
../source3/include/proto.h:62: error: expected ')' before '*' token
../source3/include/proto.h:66: error: expected ')' before '*' token
../source3/include/proto.h:104: error: expected ')' before '*' token
../source3/include/proto.h:114: error: expected ')' before '*' token
../source3/include/proto.h:118: error: expected ')' before '*' token
../source3/include/proto.h:203: error: expected ')' before '*' token
../source3/include/proto.h:242: error: expected ')' before '*' token
In file included from ../source3/include/includes.h:539,
                 from ../libgpo/gpo_ldap.c:20:
../source3/include/proto.h:243: error: expected ')' before '*' token
../source3/include/proto.h:244: error: expected ')' before '*' token
../source3/include/proto.h:249: error: expected ')' before '*' token
../source3/include/proto.h:250: error: expected ')' before '*' token
../source3/include/proto.h:253: error: expected ')' before '*' token
../source3/include/proto.h:256: error: expected ')' before '*' token
../source3/include/proto.h:258: error: expected ')' before '*' token
../source3/include/proto.h:260: error: expected ')' before '*' token
../source3/include/proto.h:262: error: expected ')' before '*' token
../source3/include/proto.h:263: error: expected ')' before '*' token
../source3/include/proto.h:264: error: expected ')' before '*' token
../source3/include/proto.h:266: error: expected ')' before '*' token
../source3/include/proto.h:268: error: expected ')' before '*' token
../source3/include/proto.h:275: error: expected ')' before '*' token
../source3/include/proto.h:286: error: expected ')' before '*' token
../source3/include/proto.h:292: error: expected ')' before '*' token
../source3/include/proto.h:293: error: expected ')' before '*' token
../source3/include/proto.h:299: error: expected ')' before '*' token
../source3/include/proto.h:326: error: expected ')' before '*' token
../source3/include/proto.h:328: error: expected ')' before '*' token
../source3/include/proto.h:334: error: expected ')' before '*' token
../source3/include/proto.h:343: error: expected ')' before '*' token
../source3/include/proto.h:477: error: expected ')' before '*' token
../source3/include/proto.h:496: error: expected ')' before '*' token
../source3/include/proto.h:497: error: expected ')' before '*' token
../source3/include/proto.h:535: error: expected ')' before '*' token
../source3/include/proto.h:536: error: expected ')' before '*' token
../source3/include/proto.h:568: error: expected ')' before '*' token
../source3/include/proto.h:569: error: expected ')' before '*' token
../source3/include/proto.h:580: error: expected ')' before '*' token
../source3/include/proto.h:583: error: expected ')' before '*' token
../source3/include/proto.h:584: error: expected ')' before '*' token
../source3/include/proto.h:586: error: expected ')' before '*' token
../source3/include/proto.h:587: error: expected ')' before '*' token
../source3/include/proto.h:622: error: expected ')' before '*' token
../source3/include/proto.h:631: error: expected ')' before '*' token
../source3/include/proto.h:644: error: expected ')' before '*' token
../source3/include/proto.h:654: error: expected ')' before '*' token
../source3/include/proto.h:669: error: expected ')' before '*' token
../source3/include/proto.h:673: error: expected ')' before '*' token
../source3/include/proto.h:701: error: expected ')' before '*' token
../source3/include/proto.h:708: error: expected ')' before '*' token
../source3/include/proto.h:726: error: expected ')' before '*' token
../source3/include/proto.h:727: error: expected ')' before '*' token
../source3/include/proto.h:755: error: expected ')' before '*' token
../source3/include/proto.h:762: error: expected ')' before '*' token
../source3/include/proto.h:788: error: expected ')' before '*' token
../source3/include/proto.h:829: error: expected ')' before '*' token
../source3/include/proto.h:835: error: expected ')' before '*' token
../source3/include/proto.h:850: error: expected ')' before '*' token
../source3/include/proto.h:860: error: expected ')' before '*' token
../source3/include/proto.h:868: error: expected declaration specifiers or '...' before 'TALLOC_CTX'
../source3/include/proto.h:898: error: expected ')' before '*' token
../source3/include/proto.h:904: error: expected ')' before '*' token
../source3/include/proto.h:909: error: expected ')' before '*' token
../source3/include/proto.h:936: error: expected ')' before '*' token
../source3/include/proto.h:939: error: expected ')' before '*' token
../source3/include/proto.h:942: error: expected ')' before '*' token
../source3/include/proto.h:943: error: expected ')' before '*' token
../source3/include/proto.h:949: error: expected ')' before '*' token
../source3/include/proto.h:950: error: expected ')' before '*' token
../source3/include/proto.h:969: error: expected ')' before '*' token
../source3/include/proto.h:977: error: expected ')' before '*' token
../source3/include/proto.h:982: error: expected ')' before '*' token
../source3/include/proto.h:983: error: expected ')' before '*' token
../source3/include/proto.h:984: error: expected ')' before '*' token
../source3/include/proto.h:989: error: expected ')' before '*' token
../source3/include/proto.h:991: error: expected ')' before '*' token
../source3/include/proto.h:992: error: expected ')' before '*' token
../source3/include/proto.h:993: error: expected ')' before '*' token
../source3/include/proto.h:995: error: expected ')' before '*' token
../source3/include/proto.h:1000: error: expected ')' before '*' token
../source3/include/proto.h:1002: error: expected ')' before '*' token
../source3/include/proto.h:1007: error: expected ')' before '*' token
../source3/include/proto.h:1021: error: expected ')' before '*' token
../source3/include/proto.h:1064: error: expected ')' before '*' token
../source3/include/proto.h:1068: error: expected declaration specifiers or '...' before 'TALLOC_CTX'
../source3/include/proto.h:1072: error: expected ')' before '*' token
../source3/include/proto.h:1083: error: expected ')' before '*' token
../source3/include/proto.h:1088: error: expected declaration specifiers or '...' before 'TALLOC_CTX'
../source3/include/proto.h:1094: error: expected declaration specifiers or '...' before 'TALLOC_CTX'
../source3/include/proto.h:1099: error: expected declaration specifiers or '...' before 'TALLOC_CTX'
../source3/include/proto.h:1116: error: expected ')' before '*' token
../source3/include/proto.h:1159: error: expected ')' before '*' token
../source3/include/proto.h:1166: error: expected ')' before '*' token
../source3/include/proto.h:1184: error: expected ')' before '*' token
../source3/include/proto.h:1209: error: expected declaration specifiers or '...' before 'TALLOC_CTX'
../source3/include/proto.h:1215: error: expected declaration specifiers or '...' before 'TALLOC_CTX'
../source3/include/proto.h:1217: error: expected ')' before '*' token
../source3/include/proto.h:1597: error: expected ')' before '*' token
../source3/include/proto.h:1643: error: expected ')' before '*' token
../source3/include/proto.h:1675: error: expected ')' before '*' token
../source3/include/proto.h:1677: error: expected ')' before '*' token
../source3/include/proto.h:1732: error: expected ')' before '*' token
../source3/include/proto.h:1749: error: expected ')' before '*' token
../source3/include/proto.h:1754: error: expected ')' before '*' token
../source3/include/proto.h:1756: error: expected ')' before '*' token
../source3/include/proto.h:1764: error: expected ')' before '*' token
../source3/include/proto.h:1779: error: expected ')' before '*' token
../source3/include/proto.h:1804: error: expected ')' before '*' token
../source3/include/proto.h:1806: error: expected ')' before '*' token
../source3/include/proto.h:1824: error: expected ')' before '*' token
../source3/include/proto.h:1826: error: expected ')' before '*' token
../source3/include/proto.h:1830: error: expected ')' before '*' token
../source3/include/proto.h:1836: error: expected ')' before '*' token
../source3/include/proto.h:1849: error: expected ')' before '*' token
In file included from ../libgpo/gpo_ldap.c:20:
../source3/include/includes.h:616: error: expected ')' before '*' token
In file included from ../source3/include/ads.h:154,
                 from ../libgpo/gpo.h:27,
                 from ../libgpo/gpo_ldap.c:21:
../source3/libads/ads_proto.h:14: error: expected declaration specifiers or '...' before 'TALLOC_CTX'
../source3/libads/ads_proto.h:45: error: expected ')' before '*' token
../source3/libads/ads_proto.h:46: error: expected ')' before '*' token
../source3/libads/ads_proto.h:48: error: expected ')' before '*' token
../source3/libads/ads_proto.h:55: error: expected ')' before '*' token
../source3/libads/ads_proto.h:71: error: expected declaration specifiers or '...' before 'TALLOC_CTX'
../source3/libads/ads_proto.h:72: error: expected declaration specifiers or '...' before 'TALLOC_CTX'
../source3/libads/ads_proto.h:73: error: expected declaration specifiers or '...' before 'TALLOC_CTX'
../source3/libads/ads_proto.h:75: error: expected declaration specifiers or '...' before 'TALLOC_CTX'
../source3/libads/ads_proto.h:78: error: expected ')' before '*' token
../source3/libads/ads_proto.h:82: error: expected declaration specifiers or '...' before 'TALLOC_CTX'
../source3/libads/ads_proto.h:83: error: expected declaration specifiers or '...' before 'TALLOC_CTX'
../source3/libads/ads_proto.h:84: error: expected declaration specifiers or '...' before 'TALLOC_CTX'
../source3/libads/ads_proto.h:89: error: expected declaration specifiers or '...' before 'TALLOC_CTX'
../source3/libads/ads_proto.h:94: error: expected declaration specifiers or '...' before 'TALLOC_CTX'
../source3/libads/ads_proto.h:98: error: expected declaration specifiers or '...' before 'TALLOC_CTX'
../source3/libads/ads_proto.h:100: error: expected ')' before '*' token
../source3/libads/ads_proto.h:107: error: expected declaration specifiers or '...' before 'TALLOC_CTX'
../source3/libads/ads_proto.h:109: error: expected declaration specifiers or '...' before 'TALLOC_CTX'
../source3/libads/ads_proto.h:111: error: expected declaration specifiers or '...' before 'TALLOC_CTX'
../source3/libads/ads_proto.h:125: error: expected declaration specifiers or '...' before 'TALLOC_CTX'
In file included from ../source3/include/ads.h:160,
                 from ../libgpo/gpo.h:27,
                 from ../libgpo/gpo_ldap.c:21:
../source3/libads/kerberos_proto.h:7: error: expected ')' before '*' token
../source3/libads/kerberos_proto.h:51: error: expected ')' before '*' token
In file included from ../libgpo/gpo_ldap.c:21:
../libgpo/gpo.h:174: error: expected ')' before '*' token
../libgpo/gpo.h:181: error: expected ')' before '*' token
../libgpo/gpo.h:186: error: expected ')' before '*' token
../libgpo/gpo.h:193: error: expected ')' before '*' token
../libgpo/gpo.h:197: error: expected declaration specifiers or '...' before 'TALLOC_CTX'
../libgpo/gpo.h:201: error: expected declaration specifiers or '...' before 'TALLOC_CTX'
../libgpo/gpo.h:206: error: expected declaration specifiers or '...' before 'TALLOC_CTX'
../libgpo/gpo.h:210: error: expected declaration specifiers or '...' before 'TALLOC_CTX'
../libgpo/gpo.h:216: error: expected declaration specifiers or '...' before 'TALLOC_CTX'
../libgpo/gpo.h:220: error: expected declaration specifiers or '...' before 'TALLOC_CTX'
../libgpo/gpo.h:238: error: expected declaration specifiers or '...' before 'TALLOC_CTX'
../libgpo/gpo.h:242: error: expected declaration specifiers or '...' before 'TALLOC_CTX'
../libgpo/gpo.h:245: error: expected declaration specifiers or '...' before 'TALLOC_CTX'
../libgpo/gpo.h:247: error: expected declaration specifiers or '...' before 'TALLOC_CTX'
../libgpo/gpo.h:254: error: expected declaration specifiers or '...' before 'TALLOC_CTX'
../libgpo/gpo.h:260: error: expected declaration specifiers or '...' before 'TALLOC_CTX'
../libgpo/gpo.h:266: error: expected declaration specifiers or '...' before 'TALLOC_CTX'
../libgpo/gpo.h:271: error: expected ')' before '*' token
../libgpo/gpo.h:275: error: expected ')' before '*' token
../libgpo/gpo.h:276: error: expected ')' before '*' token
../libgpo/gpo.h:282: error: expected declaration specifiers or '...' before 'TALLOC_CTX'
In file included from ../libgpo/gpo.h:288,
                 from ../libgpo/gpo_ldap.c:21:
../libgpo/../libgpo/gpext/gpext.h:62: error: expected ')' before '*' token
../libgpo/../libgpo/gpext/gpext.h:64: error: expected ';' before 'NTSTATUS'
../libgpo/../libgpo/gpext/gpext.h:90: error: expected ')' before '*' token
../libgpo/../libgpo/gpext/gpext.h:95: error: expected ')' before '*' token
../libgpo/../libgpo/gpext/gpext.h:101: error: expected ')' before '*' token
../libgpo/../libgpo/gpext/gpext.h:110: error: expected declaration specifiers or '...' before 'TALLOC_CTX'
../libgpo/../libgpo/gpext/gpext.h:117: error: expected declaration specifiers or '...' before 'TALLOC_CTX'
In file included from ../libgpo/gpo_ldap.c:22:
../source3/include/auth.h:105: error: expected declaration specifiers or '...' before 'TALLOC_CTX'
../source3/include/auth.h:115: error: expected declaration specifiers or '...' before 'TALLOC_CTX'
In file included from ../source3/include/auth.h:139,
                 from ../libgpo/gpo_ldap.c:22:
../source3/auth/proto.h:7: error: expected ')' before '*' token
../source3/auth/proto.h:9: error: expected ')' before '*' token
../source3/auth/proto.h:35: error: expected ')' before '*' token
../source3/auth/proto.h:44: error: expected declaration specifiers or '...' before 'TALLOC_CTX'
../source3/auth/proto.h:48: error: expected declaration specifiers or '...' before 'TALLOC_CTX'
../source3/auth/proto.h:104: error: expected ')' before '*' token
../source3/auth/proto.h:108: error: expected ')' before '*' token
../source3/auth/proto.h:119: error: expected ')' before '*' token
../source3/auth/proto.h:123: error: expected ')' before '*' token
../source3/auth/proto.h:129: error: expected ')' before '*' token
../source3/auth/proto.h:131: error: expected ')' before '*' token
../source3/auth/proto.h:135: error: expected ')' before '*' token
../source3/auth/proto.h:137: error: expected ')' before '*' token
../source3/auth/proto.h:143: error: expected ')' before '*' token
../source3/auth/proto.h:178: error: expected ')' before '*' token
../source3/auth/proto.h:191: error: expected ')' before '*' token
../source3/auth/proto.h:196: error: expected ')' before '*' token
../source3/auth/proto.h:198: error: expected ')' before '*' token
../source3/auth/proto.h:233: error: expected ')' before '*' token
../source3/auth/proto.h:238: error: expected ')' before '*' token
../source3/auth/proto.h:248: error: expected ')' before '*' token
../source3/auth/proto.h:249: error: expected ')' before '*' token
../source3/auth/proto.h:250: error: expected ')' before '*' token
../source3/auth/proto.h:254: error: expected ')' before '*' token
../source3/auth/proto.h:264: error: expected ')' before '*' token
In file included from ../libgpo/../libcli/security/security.h:100,
                 from ../libgpo/gpo_ldap.c:27:
../libcli/security/dom_sid.h:66: error: expected ')' before '*' token
../libcli/security/dom_sid.h:67: error: expected ')' before '*' token
../libcli/security/dom_sid.h:68: error: expected ')' before '*' token
../libcli/security/dom_sid.h:69: error: expected ')' before '*' token
../libcli/security/dom_sid.h:72: error: expected ')' before '*' token
../libcli/security/dom_sid.h:79: error: expected ')' before '*' token
../libcli/security/dom_sid.h:93: error: expected ')' before '*' token
../libcli/security/dom_sid.h:95: error: expected ')' before '*' token
../libcli/security/dom_sid.h:99: error: expected ')' before '*' token
In file included from ../libgpo/../libcli/security/security.h:101,
                 from ../libgpo/gpo_ldap.c:27:
../libcli/security/secace.h:30: error: expected ')' before '*' token
In file included from ../libgpo/../libcli/security/security.h:101,
                 from ../libgpo/gpo_ldap.c:27:
../libcli/security/secace.h:32: error: expected ')' before '*' token
In file included from ../libgpo/../libcli/security/security.h:102,
                 from ../libgpo/gpo_ldap.c:27:
../libcli/security/secacl.h:26: error: expected ')' before '*' token
../libcli/security/secacl.h:28: error: expected ')' before '*' token
In file included from ../libgpo/../libcli/security/security.h:103,
                 from ../libgpo/gpo_ldap.c:27:
../libcli/security/security_descriptor.h:26: error: expected ')' before '*' token
../libcli/security/security_descriptor.h:27: error: expected ')' before '*' token
../libcli/security/security_descriptor.h:48: error: expected ')' before '*' token
../libcli/security/security_descriptor.h:53: error: expected ')' before '*' token
../libcli/security/security_descriptor.h:58: error: expected ')' before '*' token
../libcli/security/security_descriptor.h:64: error: expected ')' before '*' token
../libcli/security/security_descriptor.h:67: error: expected ')' before '*' token
../libcli/security/security_descriptor.h:73: error: expected ')' before '*' token
In file included from ../libgpo/../libcli/security/security.h:104,
                 from ../libgpo/gpo_ldap.c:27:
../libcli/security/security_token.h:35: error: expected ')' before '*' token
In file included from ../libgpo/../libcli/security/security.h:105,
                 from ../libgpo/gpo_ldap.c:27:
../libcli/security/sddl.h:26: error: expected ')' before '*' token
../libcli/security/sddl.h:28: error: expected ')' before '*' token
In file included from ../libgpo/../libcli/security/security.h:106,
                 from ../libgpo/gpo_ldap.c:27:
../libcli/security/privileges.h:40: error: expected specifier-qualifier-list before 'TALLOC_CTX'
In file included from ../libgpo/../libcli/security/security.h:107,
                 from ../libgpo/gpo_ldap.c:27:
../libcli/security/access_check.h:68: error: expected ')' before '*' token
In file included from ../libgpo/../libcli/security/security.h:109,
                 from ../libgpo/gpo_ldap.c:27:
../libcli/security/display_sec.h:26: error: expected ')' before '*' token
../libgpo/gpo_ldap.c:33: error: expected ')' before '*' token
Waf: Leaving directory `/home/CORPUSERS/23059934/gnome3/samba4/bin'
Build failed:  -> task failed (err #1): 
	{task: cc gpo_ldap.c -> gpo_ldap_20.o}
make: *** [all] Error 1
Comment 1 Sean Finney 2011-05-10 08:50:05 UTC
In case it's helpful, configure line was:

env CFLAGS="-g -O0" PKG_CONFIG_PATH=$MYPREFIX/lib64/pkgconfig ./configure  --prefix=$MYPREFIX --libdir=$MYPREFIX/lib64 --with-privatelibdir=$MYPREFIX/lib64/samba

and a copy of talloc+tdb+tevent+ldb has already be installed from the same master checkout in $MYPREFIX (which before this point was entirely empty)
Comment 2 Sean Finney 2011-05-20 13:37:31 UTC
Created attachment 6460 [details]
Proposed patch

Subject: [PATCH] Fix numerous missing dependencies in WAF build scripts

With the recent consolidation of code between s3 and s4, a number of new
dependencies have been implicitly introduced.  For example, previous s3
code gained an implicit dependency on talloc after the charset related
consolidation (lib/util/charset/charset.h now includes talloc.h).  When
building against the embedded version of talloc this isn't a problem
since the paths are automatically added to the search path, but when
building against the external libraries build failures will occur for
all components that don't directly or indirectly include talloc as
a dependency.

Since charset.h is included from util.h, which in turn is included from
includes.h, this means most of the codebase (s3 and s4) has such an
undeclared dependency.

Therefore, samba-util-common and samba-util have been added as
dependencies to the s3 and s4 code respectively, for all cases where
the source would otherwise fail to build.  Additionally, a few other
dependencies are added in specific wscript_build files to address
similar dependency-related problems.
Comment 3 Matthias Dieter Wallnöfer 2011-05-20 13:55:51 UTC
Tridge, abartlet,

could you please review this?
Comment 4 Sean Finney 2011-05-20 14:26:47 UTC
Oh and I suppose I should give as a preface to that patch that I'm not too familiar with waf and there might be a better way to express the dependencies than what I'm doing.  For example, another way might be to globally just add the flags across the board to everything when using the "system" version, though I'm not sure whether you'd consider that a better or worse fix.
Comment 5 Matthias Dieter Wallnöfer 2011-05-25 07:03:31 UTC
Your patch has been reviewed by abartlet and will soon make it into "master".
Comment 6 Matthias Dieter Wallnöfer 2011-05-25 07:46:22 UTC
Needs rework
Comment 7 Sean Finney 2011-05-25 08:11:45 UTC
(In reply to comment #6)
> Needs rework

well, for future reference better feedback would be helpful.  for example, what we discussed on IRC, namely, that the source3-only build fails, ending with this error message:

[1374/1387] Linking default/source3/vlp
default/lib/util/libsamba-util-common.so: undefined reference to `sec_initial_uid'
collect2: ld returned 1 exit status
Waf: Leaving directory `/home/CORPUSERS/23059934/gnome3/samba4/source3/bin'
Build failed:  -> task failed (err #1): 
	{task: cc_link util_32.o,vlp_194.o -> vlp}
make: *** [all] Error 1

And turns out this is arguably a seperate bug.  namely, the symbol sec_initial_uid is defined in source3/lib/util_sec.c, part of the samba3core build object (or whatever it's called in waf terminology).  lib/util/debug.c, part of samba-util-common, contains a reference to this symbol, meaning that samba-util-common ought to have a dep on samba3core.  only samba3core already has a dep on samba-util-common, so you have a loop.

However, it seems to be only this one binary that has trouble linking, so the fix, simple enough, is to add samba3core (and subsequently param) as deps to the vlp build target in source3/wscript_build.

I leave it to you to decide how to resolve the circular dep in the long term, i'm guessing it's not the only one....
Comment 8 Sean Finney 2011-05-25 08:13:43 UTC
Comment on attachment 6460 [details]
Proposed patch

will update with new patch
Comment 9 Sean Finney 2011-05-25 08:15:18 UTC
Created attachment 6485 [details]
Proposed patch [v2]

Contains fix for linking vlp on s3-only builds
Comment 10 Matthias Dieter Wallnöfer 2011-05-25 16:03:17 UTC
I have not described "needs rework" further since we have discussed it on IRC. Otherwise I would have posted the reason here.

This patch works. Well done!