Bug 8099 - setpwent() actually does endpwent() and vice versa on FreeBSD
Summary: setpwent() actually does endpwent() and vice versa on FreeBSD
Status: RESOLVED FIXED
Alias: None
Product: Samba 3.5
Classification: Unclassified
Component: Winbind (show other bugs)
Version: 3.5.8
Hardware: All FreeBSD
: P5 normal
Target Milestone: ---
Assignee: Karolin Seeger
QA Contact: Samba QA Contact
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-04-19 15:23 UTC by Sergey Korsak
Modified: 2011-04-20 12:33 UTC (History)
0 users

See Also:

Attachments
Patch for nsswitch/winbind_nss_freebsd.c (1.27 KB, text/plain)
2011-04-19 15:23 UTC, Sergey Korsak 		no flags Details
Patch for 3.5 (1.67 KB, patch)
2011-04-19 16:53 UTC, Volker Lendecke 		gd: review+
Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sergey Korsak 2011-04-19 15:23:30 UTC 
Created attachment 6414 [details]
Patch for nsswitch/winbind_nss_freebsd.c

Declarations of endgrent, setgrent, endpwent and setpwent in winbind_nss_freebsd.c are mistakenly swapped.
Comment 1 Volker Lendecke 2011-04-19 16:53:50 UTC 
Created attachment 6415 [details]
Patch for 3.5

This is the patch for git am
Comment 2 Guenther Deschner 2011-04-19 21:26:18 UTC 
Comment on attachment 6415 [details]
Patch for 3.5

looks fine
Comment 3 Guenther Deschner 2011-04-19 21:26:42 UTC 
Karolin, please add to 3.5 and 3.4
Comment 4 Karolin Seeger 2011-04-20 07:38:43 UTC 
Pushed to both branches.
Closing out bug report.

Thanks!
Comment 5 Sergey Korsak 2011-04-20 12:33:18 UTC 
I believe we've fixed Bug 7829 too.
Exactly the same symptoms inspired me to investigate what's wrong.
Now 'id' shows secondary groups as well as 'getent' enumerates
domain accounts and groups.