Bug 8038 - Connecting to a printer can return INVALID_PARAMETER when IPv6 DNS names are turned on.
Summary: Connecting to a printer can return INVALID_PARAMETER when IPv6 DNS names are ...
Status: RESOLVED FIXED
Alias: None
Product: Samba 3.5
Classification: Unclassified
Component: Printing (show other bugs)
Version: 3.5.8
Hardware: All All
: P5 normal
Target Milestone: ---
Assignee: Karolin Seeger
QA Contact: Samba QA Contact
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-03-24 23:11 UTC by Jeremy Allison
Modified: 2011-04-20 18:46 UTC (History)
0 users

See Also:


Attachments
Fix for 3.5.next. (3.93 KB, patch)
2011-03-24 23:14 UTC, Jeremy Allison
gd: review+
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Jeremy Allison 2011-03-24 23:11:48 UTC
If IPv6 DNS names are turned on, but Samba isn't configured to
listen on an IPv6 interface, then is_myname_or_ipaddr() can return
false on a valid DNS name that it should detect is our own. If the
IPv6 addr is returned by preference, then looking only at the first addr
causes is_myname_or_ipaddr() to fail. This prevents us from recognizing
our own domain name as the start of a printer string.

Fix to follow.

Jeremy.
Comment 1 Jeremy Allison 2011-03-24 23:14:02 UTC
Created attachment 6345 [details]
Fix for 3.5.next.

This as already gone into master and v3-6-test. The reporter (within Google) has confirmed that this patch fixes the issue.

Guenther please review and re-assign to Karolin for inclusion in 3.5.next if you're ok with it.

Cheers,

Jeremy.
Comment 2 Guenther Deschner 2011-04-20 13:14:27 UTC
Comment on attachment 6345 [details]
Fix for 3.5.next.

looks good
Comment 3 Guenther Deschner 2011-04-20 13:14:43 UTC
Karolin, please add to 3.5
Comment 4 Karolin Seeger 2011-04-20 18:46:06 UTC
Pushed to v3-5-test.
Closing out bug report.

Thanks!