Bug 8011 - memory corruption in shadow_copy2
Summary: memory corruption in shadow_copy2
Status: RESOLVED FIXED
Alias: None
Product: Samba 3.5
Classification: Unclassified
Component: File services (show other bugs)
Version: unspecified
Hardware: All All
: P5 normal
Target Milestone: ---
Assignee: Karolin Seeger
QA Contact: Samba QA Contact
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-03-15 12:33 UTC by Volker Lendecke
Modified: 2011-03-17 14:08 UTC (History)
1 user (show)

See Also:
obnox: review+

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Volker Lendecke 2011-03-15 12:33:00 UTC 
746b299 from master must be merged to 3.5. From the checkin message:

 Fix the talloc hierarchy in shadow_copy2_connectpath

We have to return on talloc_tos() because we don't have a mem_ctx given to us.
So we have to create a separate temporary talloc context.
Comment 1 Michael Adam 2011-03-15 13:15:52 UTC 
I had to think a bit about the patch (since the talloc_new(talloc_tos()) puzzled me, but yes, this patch is needed for 3.5. :-)
Comment 2 Karolin Seeger 2011-03-17 14:08:46 UTC 
Pushed to v3-5-test.
Closing out bug report.

Thanks!