The Samba-Bugzilla – Bug 7984
Incomplete header installation
Last modified: 2011-03-15 10:50:03 UTC
installs <samba/session.h> (source4/auth/session.h before installation) that
includes "libcli/security/security.h", which isn't installed.
That breaks the openchange build (and anything else that includes <samba/session.h>.
I'll do bradh a favor and copy/paste his patch from
diff --git a/libcli/security/wscript_build b/libcli/security/wscript_build
index 3f2e06a..9696345 100644
@@ -4,7 +4,9 @@
source='dom_sid.c display_sec.c secace.c secacl.c security_descriptor.c sddl.c privileges.c security_token.c access_check.c object_tree.c create_descriptor.c util_sid.c session.c',
- deps='talloc ndr NDR_SECURITY'
+ deps='talloc ndr NDR_SECURITY',
+ public_headers='dom_sid.h secace.h secacl.h security_descriptor.h security_token.h security.h session.h sddl.h privileges.h access_check.h',
if getattr(bld.env, '_SAMBA_BUILD_', 0) == 4:
Jelmer, do you think this fix does work for us?
I have previously discussed this with the Andrews. They weren't happy to expose so much of the API (i.e. this is too many headers), and were working on an alternative solution.
Brad, please check if patch http://gitweb.samba.org/samba.git/?p=samba.git;a=commitdiff;h=a57c2b02f13569bce8e485c39924bce980a61403 fixes the problem for you.
If yes please tell me or mark the bug as "FIXED".
That isn't sufficient, but Simo has advised that he has a fix in progress that avoids exposing the underlying structures.
Fixed in samba / openchange as of http://git.samba.org/?p=samba.git;a=commit;h=7c83f69383b1bd3e0c6be95b1b53cdc2d5957623