Bug 7979 - master fails to build from source
Summary: master fails to build from source
Status: RESOLVED FIXED
Alias: None
Product: Samba 4.0
Classification: Unclassified
Component: Build (show other bugs)
Version: unspecified
Hardware: Other Linux
: P3 normal (vote)
Target Milestone: ---
Assignee: Andrew Tridgell
QA Contact: samba4-qa@samba.org
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-03-01 09:28 UTC by Sean Finney
Modified: 2011-03-01 11:07 UTC (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sean Finney 2011-03-01 09:28:36 UTC 
Hi,

today's master does not build:

[2070/2279] Compiling libds/common/flag_mapping.c
In file included from ../libds/common/flag_mapping.c:23:
../source4/include/includes.h:23:32: error: ../replace/replace.h: No such file or directory
../source4/include/includes.h:28:2: error: #error "make sure you have removed all config.h files from standalone builds!"
../source4/include/includes.h:29:2: error: #error "the included config.h isn't from samba!"
../source4/include/includes.h:33:25: error: system/time.h: No such file or directory
../source4/include/includes.h:34:25: error: system/wait.h: No such file or directory
../source4/include/includes.h:35:27: error: system/locale.h: No such file or directory
../source4/include/includes.h:54:20: error: talloc.h: No such file or directory
In file included from ../source4/include/includes.h:58,
                 from ../libds/common/flag_mapping.c:23:


Looks like some missing dependencies (talloc/replace) in the waf config?
Comment 1 Sean Finney 2011-03-01 09:38:16 UTC 
Fix:

diff --git a/libds/common/wscript_build b/libds/common/wscript_build
index 46787db..f6ed209 100644
--- a/libds/common/wscript_build
+++ b/libds/common/wscript_build
@@ -1,3 +1,4 @@
 
 bld.SAMBA_SUBSYSTEM('flag_mapping',
+                    public_deps='talloc replace',
                     source='flag_mapping.c')
Comment 2 Matthias Dieter Wallnöfer 2011-03-01 11:07:16 UTC 
Ah thanks, I will check this in.