Bug 7956 - Don't error when attempting to delete a non-existent default ACL
Don't error when attempting to delete a non-existent default ACL
Status: RESOLVED INVALID
Product: rsync
Classification: Unclassified
Component: core
3.1.0
All Linux
: P3 normal
: ---
Assigned To: Wayne Davison
Rsync QA Contact
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-02-14 20:20 UTC by Chris Dunlop
Modified: 2011-02-14 21:14 UTC (History)
0 users

See Also:


Attachments
Patch to fix deleting non-existent default ACL (360 bytes, patch)
2011-02-14 20:23 UTC, Chris Dunlop
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dunlop 2011-02-14 20:20:41 UTC
When attempting to delete a default ACL an error return of ENODATA means there
wasn't a default ACL in the first place. Don't treat this as an error as it
means we're now where we wanted to be, i.e. without a default ACL.
Comment 1 Chris Dunlop 2011-02-14 20:23:47 UTC
Created attachment 6247 [details]
Patch to fix deleting non-existent default ACL
Comment 2 Matt McCutchen 2011-02-14 20:34:54 UTC
How can the situation arise?  If it arises only by a concurrent modification to the destination, I don't care much.  There are lots of ways rsync can mess up with concurrent modifications to the destination.
Comment 3 Chris Dunlop 2011-02-14 21:14:48 UTC
I was seeing the error on an rsync -A into a fresh destination, where the destination directory itself doesn't have a default ACL.


...doh! As it turns out, the error was because my destination filesystem didn't have ACLs enabled. Sorry for the noise!